Mail archive

Re: [alpine-devel] Re: [alpine-aports] [PATCH] main/mkinitfs: backport cryptdiscards patch

From: 7heo <>
Date: Mon, 17 Jul 2017 10:46:40 +0200

On 7/14/2017 4:59 PM, Sören Tempel wrote:
> Ping?
> On 22.06.17, Sören Tempel wrote:
>> On 16.06.17, Natanael Copa wrote:
>>> Does anybody on alpine-devel have opinion on what the boot args should
>>> be for LUKS devices?
>> Doesn't seem to be the case. How about merging this into the mkinitfs
>> repository without backporting it for now? We can still change the name
>> of the kernel parameters later on.
>> Cheers,
>> Sören

Hey there,

Sorry for the lag, I couldn't answer in Friday and then the week end got
in the way.

However, I prefer the separated-variables way, and by far. Here is the

- The parsing would happen in shell (as opposed as in the initfs binary)
and I don't think doing unnecessary (for appearance only) text parsing
in shell is the sane way to go.

- Using ':' (or anything else really) as separator is assuming that this
character isn't used in any identifier in the list. In the past, present
and future. For any of those identifiers, ever. And really, we cannot
assume that.

- Separating variables with their name is way more explicit and way less
magic than establishing an arbitrary order and relying on the users to
read the documentation on what a variable does, and in what order.

- Having multiple variables grouped where it is technically incorrect
will be misleading and confusing, teaching newcomers the wrong lessons.

* * *

Long story short, I do not think that the cost (purely visual) of having
the variables separated in the configuration file is worth the technical
effort and technical risk of concatenating them. KISS.


Received on Mon Jul 17 2017 - 10:46:40 UTC