Date: Wed, 19 Feb 2020 20:42:33 +0200
From: Timo Teras <timo.teras@iki.fi>
To: "Ariadne Conill" <ariadne@dereferenced.org>
Cc: "Carl Chave" <online@chave.us>, ~alpine/apk-tools@lists.alpinelinux.org
Subject: Re: APK Package Name Issue on armel port
Message-ID: <20200219204233.49e5a568@vostro.wlan>
In-Reply-To: <4e90cb4a79798ceb74b224574a2da77c@dereferenced.org>
References: <20200219104752.01d68e90@vostro.wlan>
	<20200217123334.031047d1@vostro.wlan>
	<CAGP1gyMH+GoXnGd3YQjg4piFYpMpNiHkC7PDO7BoHTSbYsP1Ug@mail.gmail.com>
	<20200214105215.6873e402@vostro.wlan>
	<CAGP1gyOakdw54WaRNVrJFWwr4vcv410c-hUr_k4J4su6CnRBBg@mail.gmail.com>
	<62f21c96-ff43-83e4-5b7f-2e65e6d72729@adelielinux.org>
	<CAGP1gyMVCGirBd8MgNUOpiUDMsbLSSdmri3qwMLS+trh0=NWng@mail.gmail.com>
	<CAGP1gyOL_CEYcT_cEeJ=+GMccDuUi5Fv-d3q=nq70Y8HxK1bxQ@mail.gmail.com>
	<20200217111200.08405b9c@vostro.wlan>
	<340209c209104e20dd01b7b6aa71251c@dereferenced.org>
	<4e90cb4a79798ceb74b224574a2da77c@dereferenced.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 19 Feb 2020 18:17:37 +0000
"Ariadne Conill" <ariadne@dereferenced.org> wrote:

> > Though, perhaps this is becoming less important. That is, the
> > interning of most package data is not needed as we mmap the files in
> > future. If the result is that hashing is needed for short strings
> > only, such as the package name, it might be worth looking at
> > simplifying things by going to FNV-1.  
> 
> Yeah, that is what I mean.  As the current design is moving away
> from the use of interned strings, it may make more sense to use a
> simpler byte-for-byte hashing algorithm.  That way we don't have
> to worry about alignment.

Right. Though, the fix was simple (and committed now), just lead the 4
bytes by separate byte loads. It should be still better quality
and faster, as the major speed up comes from batching the mix operations
every 4 bytes, instead of having multiplication per byte.

But yeah, we can re-evaluate things with the new formats.

Timo