Subject: Re: [alpine-aports] [PATCH] testing/stardict: new aport
To: Taner Tas <taner76@gmail.com>, alpine-aports@lists.alpinelinux.org
References: <20170406210355.3490-1-taner76@gmail.com>
From: Leonardo Arena <rnalrd@gmail.com>
Message-ID: <0f6af26a-dede-3e55-b993-632ad1c75642@gmail.com>
Date: Mon, 10 Apr 2017 14:25:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20170406210355.3490-1-taner76@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="6n93hX321WLfoPHtMVcBX1q9Sp17lPNJm"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6n93hX321WLfoPHtMVcBX1q9Sp17lPNJm
Content-Type: multipart/mixed; boundary="rmPT3KT8hmKk9EfMeXPTuGTG1t1xWwwxh";
 protected-headers="v1"
From: Leonardo Arena <rnalrd@gmail.com>
To: Taner Tas <taner76@gmail.com>, alpine-aports@lists.alpinelinux.org
Message-ID: <0f6af26a-dede-3e55-b993-632ad1c75642@gmail.com>
Subject: Re: [alpine-aports] [PATCH] testing/stardict: new aport
References: <20170406210355.3490-1-taner76@gmail.com>
In-Reply-To: <20170406210355.3490-1-taner76@gmail.com>

--rmPT3KT8hmKk9EfMeXPTuGTG1t1xWwwxh
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Hi,

On 06/04/2017 23:03, Taner Tas wrote:
> http://stardict-4.sourceforge.net/
> Cross-Platform and international dictionary Software
> ---
>  testing/stardict/APKBUILD    | 67 ++++++++++++++++++++++++++++++++++++=
++++++++
>  testing/stardict/gcc46.patch | 11 ++++++++
>  testing/stardict/glib2.patch | 36 ++++++++++++++++++++++++
>  3 files changed, 114 insertions(+)
>  create mode 100644 testing/stardict/APKBUILD
>  create mode 100644 testing/stardict/gcc46.patch
>  create mode 100644 testing/stardict/glib2.patch
>=20
> diff --git a/testing/stardict/APKBUILD b/testing/stardict/APKBUILD
> new file mode 100644
> index 00000000..c8ce104a
> --- /dev/null
> +++ b/testing/stardict/APKBUILD
> @@ -0,0 +1,67 @@
> +# Contributor: Taner Tas <taner76@gmail.com>
> +# Maintainer: Taner Tas <taner76@gmail.com>
> +pkgname=3Dstardict
> +pkgver=3D3.0.6
> +pkgrel=3D0
> +pkgdesc=3D"Cross-Platform and international dictionary Software"
> +url=3D"http://stardict-4.sourceforge.net/"
> +arch=3D"all"
> +license=3D"GPL"
> +depends=3D"gtk+2.0 libsigc++ zlib"
> +makedepends=3D"gtk+2.0-dev libsigc++-dev libxml2-dev gnome-doc-utils
> +	gnome-common enchant-dev espeak-dev zlib-dev mariadb-dev gconf-dev"
> +install=3D""
> +subpackages=3D"$pkgname-doc $pkgname-lang $pkgname-help::noarch"
> +source=3D"http://downloads.sourceforge.net/project/stardict-4/${pkgver=
}/${pkgname}-${pkgver}.tar.bz2
> +	gcc46.patch
> +	glib2.patch"
> +
> +prepare() {
> +	cd "$builddir"
> +        local i
> +        for i in $source; do
> +                case $i in
> +                *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1=
;;
> +                esac
> +        done

Please use "default_prepare" instead of the "for" loop.

> +	find dict/src/sigc++* -name \*.h -or -name \*.cc | xargs rm -f || ret=
urn 1
> +}
> +
> +build() {
> +	cd "$builddir"
> +	export CXXFLAGS=3D"$CXXLAGS -std=3Dgnu++11"
> +	./autogen.sh

Autogen should be moved into prepare().

> +	./configure \
> +	--build=3D$CBUILD \
> +	--host=3D$CHOST \
> +	--prefix=3D/usr \
> +	--sysconfdir=3D/etc \
> +	--mandir=3D/usr/share/man \
> +	--localstatedir=3D/var \
> +	--disable-gnome-support \
> +	--disable-dictdotcn \
> +	--disable-gucharmap \
> +	--disable-scrollkeeper \
> +	--disable-festival \
> +	--disable-updateinfo \
> +	--disable-gpe-support \
> +	--disable-schemas-install || return 1
> +	make || return 1
> +}
> +
> +package() {
> +	cd "$builddir"
> +	make DESTDIR=3D"$pkgdir" install || return 1
> +}
> +


All "|| return 1" are no longer necessary since we use "set -e" in abuild=
=2E

Thanks!

|_eo


--rmPT3KT8hmKk9EfMeXPTuGTG1t1xWwwxh--

--6n93hX321WLfoPHtMVcBX1q9Sp17lPNJm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJY63nXAAoJELAPckZGG2T64BoIAIzxZWhLECdVZtyDj8+2gj+B
s3P4Lbr2OpuF35f5YNh7M56nEZT1wFhn90dc7/V8HyhY83N0l3FEppjNDhS2DHea
rkhTd/wJqR6P/jnAu6EDm47uuyFVlxXHbaZMvQbRPrk9wFdTpdnT6OJ5mLnh7bLU
zZrvLjx0m/mqTI056GEbaaFJVOnQzH6gvkUWxVabRleA9xaM3FPn+7h33yzq/EHk
eEqksyCLdrwyX6kbg/fGsdAD6AY6Feh1xQ8T4yyk2brWNfvrtmR1FmYnQUOeHpXS
v0vCZ4ps/cv33uQFNEL94ODJJfCMGZxa44xy+trDKKNiDXjKQLwEWwoCtMdRQBI=
=nlCo
-----END PGP SIGNATURE-----

--6n93hX321WLfoPHtMVcBX1q9Sp17lPNJm--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---