Subject: [alpine-aports] [PATCH 1/8] main/syncthing: go binaries should not be stripped

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:43 +0200

Stripping of Go binaries is not officially supported and/or tested and
can cause crashes on certain architectures. Therefore I suggest that
syncthing and (possibly) other go packages add options='!strip' to the
APKBUILD.

See also:
- https://bugs.launchpad.net/ubuntu/+source/golang/+bug/1200255/comments/8
- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717172
---
 main/syncthing/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/syncthing/APKBUILD b/main/syncthing/APKBUILD
index 4bd6c7a..e889541 100644
--- a/main/syncthing/APKBUILD
+++ b/main/syncthing/APKBUILD
@@ -3,7 +3,7 @@
 # Maintainer: Natanael Copa <[email-masked]>
 pkgname=syncthing
 pkgver=0.11.16
-pkgrel=0
+pkgrel=1
 pkgdesc="Open Source Continuous File Synchronization"
 url="http://syncthing.net/"
 arch="all"
@@ -15,6 +15,7 @@ depends_dev=""
 makedepends="$depends_dev godep go mercurial bash"
 install="$pkgname.pre-install"
 subpackages=""
+options="!strip"
 source="$pkgname-$pkgver.tar.gz::https://github.com/syncthing/syncthing/archive/v$pkgver.tar.gz
 	syncthing.confd
 	syncthing.initd"
-- 
2.5.0

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:44 +0200

---
 main/godep/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/godep/APKBUILD b/main/godep/APKBUILD
index 358bf1c..741a4b7 100644
--- a/main/godep/APKBUILD
+++ b/main/godep/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer:
 pkgname=godep
 pkgver=0_git20140825
-pkgrel=0
+pkgrel=1
 pkgdesc="Dependency tool for go"
 url="http://github.com/tools/godep"
 arch="all"
@@ -12,6 +12,7 @@ depends_dev=""
 makedepends="$depends_dev go mercurial"
 install=""
 subpackages=""
+options="!strip"
 source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.bz2"
 disturl="dev.alpinelinux.org:/archive/$pkgname/"
 
-- 
2.5.0

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:45 +0200

---
 testing/asciinema/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/asciinema/APKBUILD b/testing/asciinema/APKBUILD
index 25f9eb5..f5e423b 100644
--- a/testing/asciinema/APKBUILD
+++ b/testing/asciinema/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer: Fabian Affolter <[email-masked]>
 pkgname=asciinema
 pkgver=1.1.1
-pkgrel=1
+pkgrel=2
 pkgdesc="A Command line recorder for asciinema.org service"
 url="https://github.com/asciinema/asciinema/"
 arch="all"
@@ -11,6 +11,7 @@ depends="curl"
 depends_dev=""
 makedepends="go python"
 subpackages="$pkgname-doc"
+options="!strip"
 source="$pkgname-$pkgver.tar.gz::https://github.com/$pkgname/$pkgname/archive/v$pkgver.tar.gz"
 
 _builddir="$srcdir"/$pkgname-$pkgver
-- 
2.5.0

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:46 +0200

---
 testing/consul/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/consul/APKBUILD b/testing/consul/APKBUILD
index cef4980..3b9ec88 100644
--- a/testing/consul/APKBUILD
+++ b/testing/consul/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer:
 pkgname=consul
 pkgver=0.5.0
-pkgrel=0
+pkgrel=1
 pkgdesc="A tool for service discovery, monitoring and configuration"
 url="https://www.consul.io/"
 arch="all"
@@ -14,6 +14,7 @@ install="$pkgname.pre-install $pkgname.pre-deinstall $pkgname.post-deinstall"
 pkgusers="consul"
 pkggroups="consul"
 subpackages=""
+options="!strip"
 source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.gz
 	v${pkgver//./-}.json
 	consul.initd
-- 
2.5.0

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:47 +0200

---
 testing/docker-registry/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/docker-registry/APKBUILD b/testing/docker-registry/APKBUILD
index d5a90f4..042ff27 100644
--- a/testing/docker-registry/APKBUILD
+++ b/testing/docker-registry/APKBUILD
@@ -1,12 +1,13 @@
 # Maintainer: Chritsian Kampka <christian at kampka dot net>
 pkgname=docker-registry
 pkgver=2.0.1
-pkgrel=1
+pkgrel=2
 pkgdesc="An implementation of the Docker Registry HTTP API V2 for use with docker 1.6+."
 url="https://github.com/docker/distribution"
 arch="x86_64"
 license="Apache 2.0"
 makedepends="git go"
+options="!strip"
 source="$pkgname-$pkgver.tar.gz::${url}/archive/v${pkgver}.tar.gz
 	docker-registry.initd"
 
-- 
2.5.0

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:48 +0200

---
 testing/gogs/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/gogs/APKBUILD b/testing/gogs/APKBUILD
index d44ed4d..ecbd9d0 100644
--- a/testing/gogs/APKBUILD
+++ b/testing/gogs/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer:
 pkgname=gogs
 pkgver=0.6.1
-pkgrel=2
+pkgrel=3
 pkgdesc="A self-hosted Git service written in Go"
 url="http://gogs.io/"
 arch="all"
@@ -13,6 +13,7 @@ makedepends="$depends_dev go-tools perl"
 install="$pkgname.pre-install"
 subpackages=""
 pkgusers="gogs"
+options="!strip"
 source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.gz
 	$pkgname.initd
 	$pkgname.confd
-- 
2.5.0

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:49 +0200

---
 testing/installflash/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/installflash/APKBUILD b/testing/installflash/APKBUILD
index cc33837..e70631e 100644
--- a/testing/installflash/APKBUILD
+++ b/testing/installflash/APKBUILD
@@ -5,7 +5,7 @@ pkgname=installflash
 _sha=db1aba5b51b478c16b7e21eec5ad79a8d87d0d06
 _project="WnP/InstallFlash"
 pkgver=20150516
-pkgrel=0
+pkgrel=1
 pkgdesc="Alpine Linux FlashPlugin installer updater "
 url="https://github.com/WnP/InstallFlash"
 arch="all"
@@ -15,6 +15,7 @@ depends_dev=""
 makedepends="$depends_dev xz go"
 install=""
 subpackages=""
+options="!strip"
 source="https://github.com/$_project/archive/$_sha.tar.gz"
 
 _builddir="$srcdir"/InstallFlash-$_sha
-- 
2.5.0

---

---

From: Francesco Colista <[email-masked]>
Date: Thu, 13 Aug 2015 11:28:27 +0200

>  1 file changed, 2 insertions(+), 1 deletion(-)

patch applies but looks that the apkbuild is broken.

db1aba5b51b478c16b7e21eec5ad79a8d87d0d06.tar.gz: OK
>>> installflash: Unpacking 
>>> /var/cache/distfiles/db1aba5b51b478c16b7e21eec5ad79a8d87d0d06.tar.gz...
package github.com/WnP/InstallFlash
	imports github.com/WnP/InstallFlash
	imports github.com/WnP/InstallFlash: no buildable Go source files in 
/home/fcolista/aports/testing/installflash/src/src/github.com/WnP/InstallFlash
>>> ERROR: installflash: all failed
>>> installflash: Uninstalling dependencies...

There's no maintainer for this package.
Do we really need this?
Or could be enough this: 
http://wiki.alpinelinux.org/wiki/Installing_Adobe_flash_player_for_Firefox
and the adobe-flashplayer package in "non-free" repository?

-- 
:: Francesco Colista
:: Alpine Linux Infrstraucture
:: http://www.alpinelinux.org

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 13 Aug 2015 23:41:03 +0200

> There's no maintainer for this package.

I personally don't think that is needed and even if it would be needed
it could be a simple shell script instead of a full blown go program.

Since it doesn't even seem to have a maintainer I would definitely
welcome the removal of this package.

Sören.

---

---

From: Sören Tempel <[email-masked]>
Date: Thu, 6 Aug 2015 20:53:50 +0200

---
 testing/websocketd/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testing/websocketd/APKBUILD b/testing/websocketd/APKBUILD
index 7289018..dd633a3 100644
--- a/testing/websocketd/APKBUILD
+++ b/testing/websocketd/APKBUILD
@@ -2,7 +2,7 @@
 # Maintainer:
 pkgname=websocketd
 pkgver=0.2.10
-pkgrel=0
+pkgrel=1
 pkgdesc="Full duplex messaging between web browsers and servers"
 url="http://websocketd.com/"
 arch="all"
@@ -12,6 +12,7 @@ depends_dev=""
 makedepends="$depends_dev go go-tools"
 install=""
 subpackages="$pkgname-doc"
+options="!strip"
 source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.gz"
 
 _disturl="dev.alpinelinux.org:/archive/$pkgname/"
-- 
2.5.0

---