Hi,
TLDR: it was intentional
sorry for confusion, original email body was stripped. I have to tune my git
send-mail config a bit.
This package brings webkit2gtk-4.0 to alpine, which is the latest binary version
of webkitgtk. It is intentionaly coinstallable with binary versions 1.0 and 3.0
already present in alpine.
webkit1 (in webkit) and webkit2 are totally different and require application
rewrite to move to later. Thats why distros usually have both of them.
Last version of webkitgtk with webkit1 is 2.4.9. Also webkit2 included in 2.4.9
is slightly different from webkit2 included in 2.10 series (binary version
bumped). More details: [0].
It would definitely make things easier not to have 3 binary versions + gtk2/gtk3
versions. To keep things minimal I think it would be possible to stop building
webkit2 from 2.4.9 branch and move all dependencies to this new package. Also
xiphos which builds currently against webkit1 could be moved to this package.
Status is as follows:
could use webkit2-4.0:
* midori
* claws-mail
* xiphos
blockers for webkit1:
* shotwell [2]
* geary [1]
For the last two we could drop gtk2 build in `webkit` since the both uses gtk3.
So the minimal version could be gtk3 webkit (libwebkitgtk-3.0) from 2.4.9 and
gtk3 webkit2 (libwebkit2gtk-4.0) from latest branch.
Note to the package:
I have disabled support for gtk2 plugins which reduces binary size a lot. Flash
and similar will not work with this version.
I'm OK with maintaining it in community, but if you want to take it then even
better.
Cheers,
Jiri
[0] http://blogs.igalia.com/carlosgc/2014/08/01/webkitgtk-2-5-1-good-bye-webkit1/
[1] https://bugzilla.gnome.org/show_bug.cgi?id=728002
[2] https://bugzilla.gnome.org/show_bug.cgi?id=751709
On Tue, Nov 03, 2015 at 09:29:49AM +0100, Natanael Copa wrote:
>On Tue, 3 Nov 2015 00:32:47 +0000>Jiri Horner <horner.jiri@gmail.com> wrote:>>> http://webkitgtk.org/>> portable web rendering engine WebKit for GTK+>> --->> community/webkit2gtk/APKBUILD | 95 +++++++++++++++++++++++++>> community/webkit2gtk/disallow-ctype.patch | 11 +++>> community/webkit2gtk/disallow-malloc_trim.patch | 12 ++++>> community/webkit2gtk/fix-execinfo.patch | 20 ++++++>> community/webkit2gtk/fix-isnan.patch | 19 +++++>> 5 files changed, 157 insertions(+)>> create mode 100644 community/webkit2gtk/APKBUILD>> create mode 100644 community/webkit2gtk/disallow-ctype.patch>> create mode 100644 community/webkit2gtk/disallow-malloc_trim.patch>> create mode 100644 community/webkit2gtk/fix-execinfo.patch>> create mode 100644 community/webkit2gtk/fix-isnan.patch>>Instead of adding another webktigtk aport, how about upgrade the>existing community/webkitgtk? It provides webkit for both gtk2 and gtk3>from same aport.>>-nc
--
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On Tue, 3 Nov 2015 11:21:22 +0100
Jiri Horner <laeqten@gmail.com> wrote:
> Hi,> > TLDR: it was intentional> > sorry for confusion, original email body was stripped. I have to tune my git > send-mail config a bit.> > This package brings webkit2gtk-4.0 to alpine, which is the latest binary version > of webkitgtk. It is intentionaly coinstallable with binary versions 1.0 and 3.0 > already present in alpine.> > webkit1 (in webkit) and webkit2 are totally different and require application > rewrite to move to later. Thats why distros usually have both of them. > Last version of webkitgtk with webkit1 is 2.4.9. Also webkit2 included in 2.4.9 > is slightly different from webkit2 included in 2.10 series (binary version > bumped). More details: [0].> > It would definitely make things easier not to have 3 binary versions + gtk2/gtk3 > versions. To keep things minimal I think it would be possible to stop building > webkit2 from 2.4.9 branch and move all dependencies to this new package. Also > xiphos which builds currently against webkit1 could be moved to this package. > Status is as follows:> > could use webkit2-4.0:> * midori> * claws-mail> * xiphos> > blockers for webkit1:> * shotwell [2]> * geary [1]> > For the last two we could drop gtk2 build in `webkit` since the both uses gtk3. > So the minimal version could be gtk3 webkit (libwebkitgtk-3.0) from 2.4.9 and > gtk3 webkit2 (libwebkit2gtk-4.0) from latest branch.> > Note to the package:> > I have disabled support for gtk2 plugins which reduces binary size a lot. Flash> and similar will not work with this version.> > I'm OK with maintaining it in community, but if you want to take it then even > better.
This all sounds great to me. lets do it.
There appear to be a build error (32bit atleast):
[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o
/home/ncopa/aports/testing/webkit2gtk/src/webkitgtk-2.10.3/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp: In member function 'void WebCore::MemoryPressureHandler::platformReleaseMemory(WebCore::Critical)':
/home/ncopa/aports/testing/webkit2gtk/src/webkitgtk-2.10.3/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:205:18: error: 'malloc_trim' was not declared in this scope
malloc_trim(0);
^
Source/WebCore/CMakeFiles/WebCore.dir/build.make:60331: recipe for target 'Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o' failed
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o] Error 1
CMakeFiles/Makefile2:642: recipe for target 'Source/WebCore/CMakeFiles/WebCore.dir/all' failed
make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2
> > Cheers,> Jiri> > [0] http://blogs.igalia.com/carlosgc/2014/08/01/webkitgtk-2-5-1-good-bye-webkit1/> [1] https://bugzilla.gnome.org/show_bug.cgi?id=728002> [2] https://bugzilla.gnome.org/show_bug.cgi?id=751709> > On Tue, Nov 03, 2015 at 09:29:49AM +0100, Natanael Copa wrote:> >On Tue, 3 Nov 2015 00:32:47 +0000> >Jiri Horner <horner.jiri@gmail.com> wrote:> >> >> http://webkitgtk.org/> >> portable web rendering engine WebKit for GTK+> >> ---> >> community/webkit2gtk/APKBUILD | 95 +++++++++++++++++++++++++> >> community/webkit2gtk/disallow-ctype.patch | 11 +++> >> community/webkit2gtk/disallow-malloc_trim.patch | 12 ++++> >> community/webkit2gtk/fix-execinfo.patch | 20 ++++++> >> community/webkit2gtk/fix-isnan.patch | 19 +++++> >> 5 files changed, 157 insertions(+)> >> create mode 100644 community/webkit2gtk/APKBUILD> >> create mode 100644 community/webkit2gtk/disallow-ctype.patch> >> create mode 100644 community/webkit2gtk/disallow-malloc_trim.patch> >> create mode 100644 community/webkit2gtk/fix-execinfo.patch> >> create mode 100644 community/webkit2gtk/fix-isnan.patch> >> >Instead of adding another webktigtk aport, how about upgrade the> >existing community/webkitgtk? It provides webkit for both gtk2 and gtk3> >from same aport.> >> >-nc>
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
>>This all sounds great to me. lets do it.>>There appear to be a build error (32bit atleast):>>[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o>/home/ncopa/aports/testing/webkit2gtk/src/webkitgtk-2.10.3/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp: In member function 'void WebCore::MemoryPressureHandler::platformReleaseMemory(WebCore::Critical)':>/home/ncopa/aports/testing/webkit2gtk/src/webkitgtk-2.10.3/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:205:18: error: 'malloc_trim' was not declared in this scope> malloc_trim(0);> ^>Source/WebCore/CMakeFiles/WebCore.dir/build.make:60331: recipe for target 'Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o' failed>make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/linux/MemoryPressureHandlerLinux.cpp.o] Error 1>CMakeFiles/Makefile2:642: recipe for target 'Source/WebCore/CMakeFiles/WebCore.dir/all' failed>make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2>Makefile:149: recipe for target 'all' failed>make: *** [all] Error 2>>
I'm sorry, mea culpa. I have forgotten to add one of the patches to APKBUILD.
This patch deals with problem (glibc malloc.h extension).
New patch attached.
Jiri