Subject: [alpine-aports] [PATCH] main/rtorrent: Add libxml2-dev to ensure xmlrpc/scgi support

From: Hervé Rousseau <[email-masked]>
Date: Wed, 24 Feb 2016 07:38:26 +0000

(with correct commit msg/subject it's always better)

APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.
./configure returns this:
checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
/usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
ok

---
 main/rtorrent/APKBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
index 2ef3c4b..49a9462 100644
--- a/main/rtorrent/APKBUILD
+++ b/main/rtorrent/APKBUILD
@@ -8,7 +8,7 @@ pkgdesc="Ncurses BitTorrent client based on libTorrent"
 url="http://rakshasa.github.io/rtorrent/"
 license="GPL"
 arch="all"
-makedepends="libsigc++-dev libtorrent-dev curl-dev xmlrpc-c-dev ncurses-dev"
+makedepends="libsigc++-dev libtorrent-dev libxml2-dev curl-dev xmlrpc-c-dev ncurses-dev"
 subpackages="$pkgname-doc"
 source="http://rtorrent.net/downloads/${pkgname}-${pkgver}.tar.gz"
 
-- 
2.6.4

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Isaac Dunham <[email-masked]>
Date: Wed, 24 Feb 2016 18:49:36 -0800

> /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found

I see two issues with this patch:
- you need to bump pkgrel to trigger a rebuild

- that error means that the xmlrpc-c-config script is missing a dependency
that it should have.

In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
it's not possible to use it without libxml2-dev.

Of course, if you fix that, you'd still need to bump rtorrent to pick up
the fix (and possibly more packages).

HTH,
Isaac Dunham

---

---

From: Natanael Copa <[email-masked]>
Date: Thu, 25 Feb 2016 10:21:25 +0100

On Wed, 24 Feb 2016 18:49:36 -0800

> the fix (and possibly more packages).

I agree with Dunham on all those.

I'd also like commit message reformatted (wrap words at 72 chars,
remove text that is not intended for the git history)

Thanks!

-nc

---

---

From: Hervé Rousseau <[email-masked]>
Date: Fri, 26 Feb 2016 07:15:00 +0000

---
Changes v1 -> v2:
 - Add depends_dev on libxml2-dev
 - Bump pkgrel

 main/xmlrpc-c/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/main/xmlrpc-c/APKBUILD b/main/xmlrpc-c/APKBUILD
index cb264ca..0176c0a 100644
--- a/main/xmlrpc-c/APKBUILD
+++ b/main/xmlrpc-c/APKBUILD
@@ -1,12 +1,13 @@
 # Maintainer: Natanael Copa <[email-masked]>
 pkgname=xmlrpc-c
 pkgver=1.33.18
-pkgrel=0
+pkgrel=1
 pkgdesc="This library provides a modular implementation of XML-RPC for C and C++"
 url="http://xmlrpc-c.sourceforge.net/"
 arch="all"
 license="BSD and MIT"
 depends=
+depends_dev="libxml2-dev"
 makedepends="libtool curl-dev libxml2-dev zlib-dev"
 subpackages="$pkgname-dev $pkgname-doc $pkgname-client
 	$pkgname-client++:clientxx xmlrpc-c++:cxx $pkgname-abyss"
-- 
2.6.4

---

---

From: Hervé Rousseau <[email-masked]>
Date: Fri, 26 Feb 2016 07:15:01 +0000

---
Changes v1 -> v2:
- Bump pkgrel to trigger rebuild with XMLRPC support

diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
index 2ef3c4b..37484ce 100644
--- a/main/rtorrent/APKBUILD
+++ b/main/rtorrent/APKBUILD
@@ -3,7 +3,7 @@
 # Maintainer: Bartłomiej Piotrowski <[email-masked]>
 pkgname=rtorrent
 pkgver=0.9.6
-pkgrel=1
+pkgrel=2
 pkgdesc="Ncurses BitTorrent client based on libTorrent"
 url="http://rakshasa.github.io/rtorrent/"
 license="GPL"
-- 
2.6.4

---

---

From: Natanael Copa <[email-masked]>
Date: Fri, 26 Feb 2016 14:59:51 +0100

On Fri, 26 Feb 2016 07:15:00 +0000

>  - Add depends_dev on libxml2-dev

Thank you for 2 beautiful patches!

-nc

---