Message-ID: <1483695001.18348.30.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH] testing/node-sodium: new aport
From: Leonardo Arena <rnalrd@gmail.com>
To: Corey Oliver <corey.jon.oliver@gmail.com>, 
	alpine-aports@lists.alpinelinux.org
Date: Fri, 06 Jan 2017 10:30:01 +0100
In-Reply-To: <20170106022751.26733-1-corey.jon.oliver@gmail.com>
References: <20170106022751.26733-1-corey.jon.oliver@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-TU3MJiS9NNWLas8pdli6"
Precedence: list
Mime-Version: 1.0


--=-TU3MJiS9NNWLas8pdli6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,
thank you for your contribution.

Please see comment below.

On gio, 2017-01-05 at 20:27 -0600, Corey Oliver wrote:
> ---
> =C2=A0testing/node-sodium/APKBUILD=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 52
> +++++++++++++++++++++++++++++
> =C2=A0testing/node-sodium/fix-gyp-binding.patch=C2=A0=C2=A0=C2=A0| 11 +++=
+++
> =C2=A0testing/node-sodium/remove-preinstall.patch | 10 ++++++
> =C2=A03 files changed, 73 insertions(+)
> =C2=A0create mode 100644 testing/node-sodium/APKBUILD
> =C2=A0create mode 100644 testing/node-sodium/fix-gyp-binding.patch
> =C2=A0create mode 100644 testing/node-sodium/remove-preinstall.patch
>=20
> diff --git a/testing/node-sodium/APKBUILD b/testing/node-
> sodium/APKBUILD
> new file mode 100644
> index 0000000..1ea95ac
> --- /dev/null
> +++ b/testing/node-sodium/APKBUILD
> @@ -0,0 +1,52 @@
> +# Contributor: Corey Oliver <coreyjonoliver@gmail.com>
> +# Maintainer: Corey Oliver <coreyjonoliver@gmail.com>
> +pkgname=3Dnode-sodium
> +_pkgname=3Dsodium
> +pkgver=3D1.2.3
> +pkgrel=3D0
> +pkgdesc=3D"Port of the lib sodium encryption library to Node.js"
> +url=3D"https://github.com/paixaop/node-sodium"
> +arch=3D"all"
> +license=3D"MIT"
> +depends=3D"nodejs libsodium=3D1.0.11-r0"
> +makedepends=3D"libsodium-dev=3D1.0.11-r0 python2"
> +source=3D"$pkgname-$pkgver.tar.gz::https://github.com/paixaop/$pkgname
> /archive/$pkgver.tar.gz
> +fix-gyp-binding.patch
> +remove-preinstall.patch
> +"
> +builddir=3D"$srcdir/$pkgname-$pkgver"
> +
> +prepare() {
> +=C2=A0=C2=A0=C2=A0=C2=A0local i
> +	cd "$builddir"
> +	for i in $source; do
> +		case $i in
> +		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return
> 1;;
> +		esac
> +	done
> +}


abuild "default_prepare" function does this for you now. Make sure to
keep "return 1" though.

Thanks!

-|_eo

--=-TU3MJiS9NNWLas8pdli6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYb2OZAAoJELAPckZGG2T6qFwH/ipAY9/BCmLBNvU/a/Bn2GVX
4bHSXy6u0EmA3X9HZP8kgzdFwX8BGxbkduVQ/XULOjhr368G+h1BKxN+pAbmaZse
S+ev7cfG/Y8mvGVJwKQk1fznhYwiVMh4XDStAIEyMUWu4o+SfbKfNHhXU9/HpD2g
x2esNg27ojvUduM5H0SQk+3AsDsCLQVZ4Od3AeWSZKjIDiQZFCKR1EJb+5sCdwTt
wFeTKGNZydEn8/MPye5fqPF6Xd41Uh9/eYbbbOhRtO81KQQs7+8Jbo1T66kxpDg2
5MaGKOzJySpSO51FspSvyRJp8Xz395sotlUpApMT/qej7jpudpycbPLEhjuoY2w=
=dzOn
-----END PGP SIGNATURE-----

--=-TU3MJiS9NNWLas8pdli6--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---