Message-ID: <1483949191.6421.7.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH v2] testing/node-sodium: new aport
From: Leonardo Arena <rnalrd@gmail.com>
To: Corey Oliver <corey.jon.oliver@gmail.com>, 
	alpine-aports@lists.alpinelinux.org
Date: Mon, 09 Jan 2017 09:06:31 +0100
In-Reply-To: <20170107001054.29747-1-corey.jon.oliver@gmail.com>
References: <20170107001054.29747-1-corey.jon.oliver@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-a7221XjHuUsXj7UxCnS2"
Precedence: list
Mime-Version: 1.0


--=-a7221XjHuUsXj7UxCnS2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

thank you for the updated patch.

On ven, 2017-01-06 at 18:10 -0600, Corey Oliver wrote:
> ---
> Changes v1 -> v2:
> =C2=A0- use the built-in abuild function default_prepare
>=20
> =C2=A0testing/node-sodium/APKBUILD=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 48
> +++++++++++++++++++++++++++++
> =C2=A0testing/node-sodium/fix-gyp-binding.patch=C2=A0=C2=A0=C2=A0| 11 +++=
++++
> =C2=A0testing/node-sodium/remove-preinstall.patch | 10 ++++++
> =C2=A03 files changed, 69 insertions(+)
> =C2=A0create mode 100644 testing/node-sodium/APKBUILD
> =C2=A0create mode 100644 testing/node-sodium/fix-gyp-binding.patch
> =C2=A0create mode 100644 testing/node-sodium/remove-preinstall.patch
>=20
> diff --git a/testing/node-sodium/APKBUILD b/testing/node-
> sodium/APKBUILD
> new file mode 100644
> index 0000000..b96b409
> --- /dev/null
> +++ b/testing/node-sodium/APKBUILD
> @@ -0,0 +1,48 @@
> +# Contributor: Corey Oliver <coreyjonoliver@gmail.com>
> +# Maintainer: Corey Oliver <coreyjonoliver@gmail.com>
> +pkgname=3Dnode-sodium
> +_pkgname=3Dsodium
> +pkgver=3D1.2.3
> +pkgrel=3D0
> +pkgdesc=3D"Port of the lib sodium encryption library to Node.js"
> +url=3D"https://github.com/paixaop/node-sodium"
> +arch=3D"all"
> +license=3D"MIT"
> +depends=3D"nodejs libsodium=3D1.0.11-r0"

Libraries are automatically detect by abuild, so you don't need to
explicitly add them. So I committed your patch, with "depends" updated.

Sorry for missing this in the previous email.

Thanks!

-|_eo

--=-a7221XjHuUsXj7UxCnS2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYc0SHAAoJELAPckZGG2T6tq4H/2RL+ybQ19Sub1SLGTBxtkph
FhRXVm+ECZbgm1Wv13zmW9mz/cWOYPtvEg/JdmhRauuk1IjwAKPS4GEyosrsdt4P
0GWokEXBjQF4NwP5wqJQAvtOF5NJ3HAvFSRH8cw5Va/Rb1nKSnkTlq5+PH1KlmRz
m4eOukXtTumdpq+Az0DDhgv7TxCiUDCdVKE9hbFwAITooLU8+FHG+4WcYJvUazG7
sYObF70qPjEaYM/WaOsx+9cvfahhGCjzuzHhX+Pe1UnXqTdQRIfk/ufCXlZq5C0I
eqjavohk8HYY4K4tqijsE3lFVhlSQhHkhoOplYIQlIR1SiaKqeuG86pA9dk7EYo=
=K46O
-----END PGP SIGNATURE-----

--=-a7221XjHuUsXj7UxCnS2--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---