Message-ID: <1485169970.11710.3.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH] testing/vice: new aport
From: Leonardo Arena <rnalrd@gmail.com>
To: Jean-Louis Fuchs <ganwell@fangorn.ch>, 
	alpine-aports@lists.alpinelinux.org
Date: Mon, 23 Jan 2017 12:12:50 +0100
In-Reply-To: <20170120213842.11471-1-ganwell@fangorn.ch>
References: <20170120213842.11471-1-ganwell@fangorn.ch>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-Ao9B4tIrolQRpeltW/DW"
Precedence: list
Mime-Version: 1.0


--=-Ao9B4tIrolQRpeltW/DW
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On ven, 2017-01-20 at 22:38 +0100, Jean-Louis Fuchs wrote:
> ---
> =C2=A0testing/vice/APKBUILD=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 54
> +++++++++++++++++++++++++++++++++++++
> =C2=A0testing/vice/disable-fc-cache.patch | 16 +++++++++++
> =C2=A0testing/vice/fix__u_char.patch=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=
 13 +++++++++
> =C2=A03 files changed, 83 insertions(+)
> =C2=A0create mode 100644 testing/vice/APKBUILD
> =C2=A0create mode 100644 testing/vice/disable-fc-cache.patch
> =C2=A0create mode 100644 testing/vice/fix__u_char.patch
>=20
> diff --git a/testing/vice/APKBUILD b/testing/vice/APKBUILD
> new file mode 100644
> index 0000000000..93357acf64
> --- /dev/null
> +++ b/testing/vice/APKBUILD
> @@ -0,0 +1,54 @@
> +# Contributor: Jean-Louis Fuchs <ganwell@fangorn.ch>
> +# Maintainer: Jean-Louis Fuchs <ganwell@fangorn.ch>
> +pkgname=3Dvice
> +pkgver=3D3.0
> +pkgrel=3D0
> +pkgdesc=3D"emulates the C64/DTV, C128, VIC20, almost all PETs, PLUS4
> and CBM-II"
> +url=3D"http://vice-emu.sourceforge.net/"
> +arch=3D"all"
> +license=3D"GPL"
> +depends=3D""
> +makedepends=3D"sdl2-dev giflib-dev ffmpeg-dev jpeg-dev alsa-lib-dev
> +	linux-headers texinfo automake autoconf bison flex"
> +install=3D""
> +subpackages=3D"$pkgname-doc"
> +source=3D"http://downloads.sourceforge.net/vice-emu/vice-$pkgver.tar.g
> z
> +	disable-fc-cache.patch
> +	fix__u_char.patch"
> +builddir=3D"$srcdir"/$pkgname-$pkgver
> +
> +prepare() {
> +	cd "$builddir"
> +	for i in $source; do
> +		case $i in
> +		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return
> 1;;
> +		esac
> +	done


Would you please use here "default_prepare || return 1" ?

Other than this it looks good.

Thanks!


-|_eo
--=-Ao9B4tIrolQRpeltW/DW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYheUyAAoJELAPckZGG2T6J8MH+wSxjDxN1NGYpfTr9MR9GwI3
0lphbXrFIKSKjM329rfjrRZAAo6fCA7I6GkesgGxUBoR53mchecE/DI5vfjjYey6
U7udendfw7TQ6Zq15rkncgsUOBldPac0YF7hZi/459svPYC30JEHqMqGc2izO8JX
ph+JOzcbi0RbDSW4J0wVA9IXaJPyVm2HJ61mXMeSJvQvVLS6OgaNCbvtixUyP3ZN
V4hQhbTGkSAIOENGu/PS5f7StMQ5WNk8TvP/F0+pQufeEKoaCeFaEOyx8TPJ5hTb
UzdbqgZFeRjXY6Yc4hNZ1EgayG6cHuY/m7dJXyFlqpHzz17tUg7ccFmEcoRT2qY=
=UU/r
-----END PGP SIGNATURE-----

--=-Ao9B4tIrolQRpeltW/DW--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---