Message-ID: <1485176528.11710.9.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH] main/perl-encode: upgrade to 2.88
From: Leonardo Arena <rnalrd@gmail.com>
To: Valery Kartel <valery.kartel@gmail.com>, 
	alpine-aports@lists.alpinelinux.org
Date: Mon, 23 Jan 2017 14:02:08 +0100
In-Reply-To: <20170123115119.32715-1-valery.kartel@gmail.com>
References: <20170123115119.32715-1-valery.kartel@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-CW8hyXQiedEiMQn/E4O5"
Precedence: list
Mime-Version: 1.0


--=-CW8hyXQiedEiMQn/E4O5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote:
> - fix doc
> - move *.pod to -doc
> - rename -piconv subpackage to -utils (because there are several
> utils)
> - move development script and data to -dev
> ---
> =C2=A0main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++--
> ------------
> =C2=A01 file changed, 35 insertions(+), 15 deletions(-)
>=20

[...]=C2=A0

> -# we split out /usr/bin/piconv to separate package to avoid conflict
> with
> -# piconv shipped with perl itself
> -piconv() {
> -	pkgdesc=3D"perl implementation of iconv"
> +utils() {
> +	pkgdesc=3D"perl Encode utils"
> +	replaces=3D"perl-utils"
> +	mkdir -p "$subpkgdir"/usr
> +	mv "$pkgdir"/usr/bin "$subpkgdir"/usr/
> +}
> +

there's no package "perl-utils" to be replaced. piconv and encguess
belong to main perl package:

(1/1) Installing perl-encode-utils (2.88-r0)
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess
owned by perl-5.24.0-r0.
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv
owned by perl-5.24.0-r0.

> +dev() {
> +	default_dev
> +	replaces=3D"perl-dev"
> =C2=A0	mkdir -p "$subpkgdir"/usr/bin
> -	mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/bin/
> +	mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/bin || reutrn 1

Spelling error =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0^

Other than these it looks okay to me.

Thanks!

-|_eo


--=-CW8hyXQiedEiMQn/E4O5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYhf7QAAoJELAPckZGG2T69fIH/39DzjEQKLyT4NdxzpMleRKd
NcCuE4NeOnZdIcEhAyZrPdGMID+NBxOCcyyVoDorYYbE/Q3bL8Evr8GBoHvrnR7i
SeL2dhN5mrtYsV7SoYSZffUq3uBuGS8IzWqi74v6+jQnttussvOlMbx2+lkTJTb8
IkfoRTMm2o1gHSkSqCGDhg+Wxh0vw3rrYCPrA4YPgRsiPJuYpEFzRx6d89tRNzEt
MGlyVp+QY5hpNmlnqIQ4UfTE7UYw2V15wUEKjs3t9QZxxuiR7vVEtGI1dJEgY4y3
H6AefqzfId4+brc3qIzMx1ZAoaLl5hPaacYCa/ZhJjqpUov1au4g3wzWXmbf/mg=
=7ARf
-----END PGP SIGNATURE-----

--=-CW8hyXQiedEiMQn/E4O5--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---