X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-wj0-f174.google.com (mail-wj0-f174.google.com [209.85.210.174]) by lists.alpinelinux.org (Postfix) with ESMTP id 575C45C41C8 for ; Mon, 23 Jan 2017 15:41:03 +0000 (GMT) Received: by mail-wj0-f174.google.com with SMTP id b20so417635wjs.2 for ; Mon, 23 Jan 2017 07:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version; bh=w9z4tZ55AhtWo689+eO2tIoSoQZ+Lt5mdI13RCl6WPU=; b=O9EX8MY2SJBk6+a4Pdbi7ImCxRiF8NmYigfWH4IiQYrxiVVvqe5HSSz1v2gn20c4Zd wzyiZXk/YLaeBwTvFTTPd0S+bGfO/MHhxmIFqCDMdPJevSlDUG3dvi6pupPylO/hEeDD QDAB9SCCuORL2uLgdTuG4u56ng7ialHqbCO1IPj2Vt13gOcY55cEtvwwfKKpgIPNNuYZ TAL1u/QVOO/i69RRA4/o3B9qBgi/Zt/7XoMs1RTcuB+zyRqboSndXitpZxLSOMYTP9kb 30Hjd2ZJXm5KHuoT+mq1vfS5hcdtcNuToj+FoYGH65ET54Ws4h9ix2waQ81ZomjUUhC/ z7og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version; bh=w9z4tZ55AhtWo689+eO2tIoSoQZ+Lt5mdI13RCl6WPU=; b=DN5xtyjodwPzNTf3WefD3Zmj3U73/3GLxvkw/+3X8nCETDwMMk71/1S96nT6/x7qqz HuIGXBuOnsJFM5CyCWWsBcF2CQ67SaI1iklh3yMq8hklUsU0uoLjxhZBnCvsjrFeRIlU Imb5G3rbsnIBmKVphfP0BMPnfukcVStyAAR91cOZt7RUuEY/yxxt6crv2gsh102JtB0P d6Rvrzhcq0WNAtdykWCTM9pWasb0SA9X06eawj137ZzrsBYs4EuB4QL3ueKyIHvaWimT 739I4Q299RCNei0lAE7PRmtkomHa8Gylmz1IZclv6JDCCNzzUbyOWdsoOCg4P0EGaczn Fusg== X-Gm-Message-State: AIkVDXJqRk6aE4TCncscKflBy3hhSYRyylaOyT8cAb2dWPbBTho623ac/TvFRWqkS3b6PA== X-Received: by 10.223.150.84 with SMTP id c20mr24370152wra.178.1485186062551; Mon, 23 Jan 2017 07:41:02 -0800 (PST) Received: from df1844j.local ([89.202.239.221]) by smtp.googlemail.com with ESMTPSA id v102sm15251327wrb.11.2017.01.23.07.41.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2017 07:41:01 -0800 (PST) Message-ID: <1485186055.11710.16.camel@gmail.com> Subject: Re: [alpine-aports] [PATCH] main/perl-encode: upgrade to 2.88 From: Leonardo Arena To: Valery Kartel Cc: alpine-aports Date: Mon, 23 Jan 2017 16:40:55 +0100 In-Reply-To: References: <20170123115119.32715-1-valery.kartel@gmail.com> <1485176528.11710.9.camel@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-28bkapnt8+Kp1uKChvnu" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: Mime-Version: 1.0 --=-28bkapnt8+Kp1uKChvnu Content-Type: multipart/alternative; boundary="=-F6faar9PEaM97u1pUt+j" --=-F6faar9PEaM97u1pUt+j Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks On lun, 2017-01-23 at 15:24 +0200, Valery Kartel wrote: > What do you think about to apply perl fixes http://patchwork.alpineli > nux.org/patch/2816/=C2=A0 ? >=20 > 2017-01-23 15:07 GMT+02:00 Valery Kartel : > > Oh, > >=20 > > previously I post http://patchwork.alpinelinux.org/patch/2816/ and > > somehow thought it's accepted and used it on my own build host. > >=20 > > for now it replaces=3D"perl" :) > >=20 > > 2017-01-23 15:02 GMT+02:00 Leonardo Arena : > > > Hi, > > >=20 > > > On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote: > > > > - fix doc > > > > - move *.pod to -doc > > > > - rename -piconv subpackage to -utils (because there are > > > several > > > > utils) > > > > - move development script and data to -dev > > > > --- > > > > =C2=A0main/perl-encode/APKBUILD | 50 > > > +++++++++++++++++++++++++++++++++-- > > > > ------------ > > > > =C2=A01 file changed, 35 insertions(+), 15 deletions(-) > > > > > > >=20 > > > [...]=C2=A0 > > >=20 > > > > -# we split out /usr/bin/piconv to separate package to avoid > > > conflict > > > > with > > > > -# piconv shipped with perl itself > > > > -piconv() { > > > > -=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl implementation of iconv" > > > > +utils() { > > > > +=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl Encode utils" > > > > +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-utils" > > > > +=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr > > > > +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin "$subpkgdir"/usr/ > > > > +} > > > > + > > >=20 > > > there's no package "perl-utils" to be replaced. piconv and > > > encguess > > > belong to main perl package: > > >=20 > > > (1/1) Installing perl-encode-utils (2.88-r0) > > > ERROR: perl-encode-utils-2.88-r0: trying to overwrite > > > usr/bin/encguess > > > owned by perl-5.24.0-r0. > > > ERROR: perl-encode-utils-2.88-r0: trying to overwrite > > > usr/bin/piconv > > > owned by perl-5.24.0-r0. > > >=20 > > > > +dev() { > > > > +=C2=A0 =C2=A0 =C2=A0default_dev > > > > +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-dev" > > > > =C2=A0=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr/bin > > > > -=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/b= in/ > > > > +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/b= in || > > > reutrn 1 > > >=20 > > > Spelling error =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ > > >=20 > > > Other than these it looks okay to me. > > >=20 > > > Thanks! > > >=20 > > > -|_eo > > >=20 > > >=20 > >=20 --=-F6faar9PEaM97u1pUt+j Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Waiting for ncopa to ACK those changes, since he's the maintainer= . I think he already replied.

Thanks
On lun, 2017-01-23 at 15:24 +0200, Valery Kartel wrote:
What do you think about to apply p= erl fixes http://patchwork.alpinelinux.org/patch/2816/  ?

2017-01-2= 3 15:07 GMT+02:00 Valery Kartel <valery.kartel@gmail.com>:
Oh,

previously I post http://patchwork.alpinelinux.org/patch/2816/ = and somehow thought it's accepted and used it on my own build host.

=
for now it replaces=3D"perl" :)

2017-= 01-23 15:02 GMT+02:00 Leonardo Arena <rnalrd@gmail.com>:
<= blockquote type=3D"cite">Hi,

On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote:
> - fix doc
> - move *.pod to -doc
> - rename -piconv subpackage to -utils (because there are several
> utils)
> - move development script and data to -dev
> ---
>  main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++--
> ------------
>  1 file changed, 35 insertions(+), 15 deletions(-)
>

[...] 

> -# we split out /usr/bin/piconv to separate package to avoid conflict<= br> > with
> -# piconv shipped with perl itself
> -piconv() {
> -     pkgdesc=3D"perl implementation of iconv"
> +utils() {
> +     pkgdesc=3D"perl Encode utils"
> +     replaces=3D"perl-utils"
> +     mkdir -p "$subpkgdir"/usr
> +     mv "$pkgdir"/usr/bin "$subpkgdir"/usr/
> +}
> +

there's no package "perl-utils" to be replaced. piconv and encguess<= br> belong to main perl package:

(1/1) Installing perl-encode-utils (2.88-r0)
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess
owned by perl-5.24.0-r0.
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv
owned by perl-5.24.0-r0.

> +dev() {
> +     default_dev
> +     replaces=3D"perl-dev"
>       mkdir -p "$subpkgdir"/usr/bin
> -     mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/bin/=
> +     mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/bin = || reutrn 1

Spelling error               &nbs= p;                     &n= bsp;        ^

Other than these it looks okay to me.

Thanks!

-|_eo






--=-F6faar9PEaM97u1pUt+j-- --=-28bkapnt8+Kp1uKChvnu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJYhiQHAAoJELAPckZGG2T69eMH/36ey5EVQY2SQfzuHFcm8aSh dz3JKSx4kWQvUwUFCNp4GqY9F4Fr91RpisBzDe5Hj+pL1tsb+Y4DxcGcQnSnMIR3 13OIFPdN5ErccAF0Dua6xJeK/HBF18LkHsqOS4ZUmbu5/UmAynx4TSIPTL74AIRg aTRfe0EDSUKXSNA8MUJyHgfIYN9Nc4ZgF2mFm6m28C+7IE0Q/M2vqaE+nWFEqO17 490CcxA1dXK+ia3OaljmTnaZz7pphnDFXKE2tAJOyh2tpi3NwXFHgQG65DJsvkBw 5ffbBtyCuEAPvj7DJug/cwq1/NN1KD2IpOgxR9HO9tk/chEtCnbDWGmesQYj1RA= =Kjb7 -----END PGP SIGNATURE----- --=-28bkapnt8+Kp1uKChvnu-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---