Message-ID: <1488383121.11710.407.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH] testing/libecap: new aport
From: Leonardo Arena <rnalrd@gmail.com>
To: Roger Newman <roger.newman@riseup.net>, 
	alpine-aports@lists.alpinelinux.org
Date: Wed, 01 Mar 2017 16:45:21 +0100
In-Reply-To: <c41dc00d-c608-6c7b-c198-2602a01c3897@riseup.net>
References: <c41dc00d-c608-6c7b-c198-2602a01c3897@riseup.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-4yv7g7b3nS7mriKcZXo3"
Precedence: list
Mime-Version: 1.0


--=-4yv7g7b3nS7mriKcZXo3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,
thank you for your contribution!

Please see some comments below.

On mar, 2017-02-28 at 20:27 +0100, Roger Newman wrote:
> http://www.e-cap.org/
> eCAP allows an HTTP proxy or an ICAP server, to outsource content
> analysis and adaptation to a loadable module
>=20
> ---
> =C2=A0testing/libecap/APKBUILD | 45
> +++++++++++++++++++++++++++++++++++++++++++++
> =C2=A01 file changed, 45 insertions(+)
> =C2=A0create mode 100644 testing/libecap/APKBUILD
>=20
> diff --git a/testing/libecap/APKBUILD b/testing/libecap/APKBUILD
> new file mode 100644
> index 0000000000..296b04e8c0
> --- /dev/null
> +++ b/testing/libecap/APKBUILD
> @@ -0,0 +1,45 @@
> +# Contributor: Roger Newman <roger.newman@riseup.net>
> +# Maintainer: Roger Newman <roger.newman@riseup.net>
> +pkgname=3Dlibecap
> +pkgver=3D1.0.0
> +pkgrel=3D0
> +pkgdesc=3D"eCAP allows an HTTP proxy or an ICAP server, to outsource
> content analysis and adaptation to a loadable module"
> +url=3D"http://www.e-cap.org/"
> +arch=3D"all"
> +license=3D"BSD"
> +depends=3D""
> +subpackages=3D"$pkgname-dev"
> +source=3D"http://www.measurement-factory.com/tmp/ecap/$pkgname-$pkgver
> .tar.gz"
> +
> +_builddir=3D"$srcdir"/$pkgname-$pkgver
> +prepare() {
> +	local i
> +	cd "$_builddir"
> +	for i in $source; do
> +		case $i in
> +		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return
> 1;;
> +		esac
> +	done

This function is now provided by abuild with "default_prepare".

> +	update_config_sub || return 1
> +}
> +
> +build() {
> +	cd "$_builddir"
> +	./configure 'CXXFLAGS=3D-O2 -m64 -pipe' 'CFLAGS=3D-O2 -m64=20

We're using by default "-Os". Also "-m64" most likely is broken on x86.
Can the default CFLAGS/CXXFLAGS be used instead?

Thanks!

|_eo
--=-4yv7g7b3nS7mriKcZXo3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYtuyRAAoJELAPckZGG2T6WFwH/RvBX7jS/bkKpfp6Z0Dzh/lH
jFclC8ZYIpFYSrcJAcVYUeKK/iIwMWpACRq6q+Yy+FKLwOrKCBNSvdI5ymqk3Emk
OW27hzB8kJTKmBllAQ0fAmGPkHtHyfhY6+dZeByhkAi83gjEpjO19uF9ZRaFbJWg
5OwtTZ56wKOJin3nkpqAH+gt7vBID0AR5ynwtg99Qp+q68rFhlBVIF34NSp0l6yY
7eKKpakNlwV6TBh0NLezmmTAcEBLe0Vh6e9ilJnoKI6A55wwqSnC3k/I3WBcludd
fqNVW64slL1IdCfxnAjohk3tBloIlH3AJvklz5Mag0fSmd44aMbgncY9Pw1hh1w=
=VoGY
-----END PGP SIGNATURE-----

--=-4yv7g7b3nS7mriKcZXo3--



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---