DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=date:from:to:cc:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; 
  b=ipEbAzOvHBleciIIVZd+xaPzTaXWI8RlXlGvRuAXkhBjqGhMHJwR5uVNEOiUhp5X8YSUanfOVPXg
    KttBc+/yW1l6wZOZainidsA8DbXa7JgqU+zP7vxtSIJ3KvgIuWI9  
Date: Wed, 18 Jan 2017 21:52:01 +0100
From: =?UTF-8?Q?Przemys=C5=82aw_Pawe=C5=82czyk?= <przemoc@zoho.com>
To: "Leonardo Arena" <rnalrd@gmail.com>
Cc: <ncopa@alpinelinux.org>,  <alpine-aports@lists.alpinelinux.org>, 
	 <zhoumichaely@gmail.com>
Message-ID: <159b359c343.df2494d47904.5259965377121748158@zoho.com>
In-Reply-To: <1484744349.8117.5.camel@gmail.com>
References: <20170114005016.27359-1-przemoc@zoho.com>
	 <20170114194146.26046-1-przemoc@zoho.com> <1484744349.8117.5.camel@gmail.com>
Subject: Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in
 APKBUILD. Change maintainer.
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Zoho Mail

Hi!

 ---- On Wed, 18 Jan 2017 13:59:09 +0100 Leonardo Arena <rnalrd@gmail.com> =
wrote ----=20
 > On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote:=20
 > > Old alleged maintainer (Michael Zhou) made himself maintainer with=20
 > > commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched=
=20
 > > nano ever again.  He has almost no trace of any activity in aports=20
 > > repo=20
 > > since 2011 (1 commit in 2016).=20
 > > =20
 > > Natanael Copa is the most active contributor, so hopefully he's not=20
 > > against becoming maintainer of another package.=20
 > > ---=20
 > > =20
 > > =C5=81ukasz Jendrysik was not aware of my nano upgrade in patchwork,=
=20
 > > so he did PR in github and Jakub Jirutka applied it quickly then.=20
 > > Here is the remaining part of my original patch.=20
 > > =20
 > > =20
 > >  main/nano/APKBUILD | 5 ++---=20
 > >  1 file changed, 2 insertions(+), 3 deletions(-)=20
 > > =20
 > > diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD=20
 > > index 3bbd36ac9945..ccdfc2f661d9 100644=20
 > > --- a/main/nano/APKBUILD=20
 > > +++ b/main/nano/APKBUILD=20
 > > @@ -1,13 +1,12 @@=20
 > >  # Contributor: Michael Mason <ms13sp@gmail.com>=20
 > > -# Maintainer: Michael Zhou <zhoumichaely@gmail.com>=20
 > > +# Maintainer: Natanael Copa <ncopa@alpinelinux.org>=20
 > >  pkgname=3Dnano=20
 > >  pkgver=3D2.7.4=20
 > > -pkgrel=3D0=20
 > > +pkgrel=3D1=20
 > =20
 > I don't think we need to really rebuild the package for this. Hence=20
 > pkgrel can be left untouched.=20

AFAIK pkgs.alpinelinux.org updates its info when the package is built, ther=
efore I think it's good to bump pkgrel. Changing maintainer should be refle=
cted in AL services.
=20
In the old days (not that long ago) ncopa requested that each change in APK=
BUILD should lead to pkgrel bump, which is a safe and sane approach, even i=
f a bit wasteful.

Some time ago APKBUILD improvements started to be applied without pkgrel bu=
mp, which can be acceptable in case of trivial changes (like my removal of =
empty vars here and there), but shouldn't be acceptable in general (like _b=
uilddir -> builddir rename and prepare() removal, because different code pa=
th in abuild is performed then).

Changing maintainer, while being trivial in diff, is important change, thus=
 I strongly suggest to not drop pkgrel bump from this patch.

 > Thanks!=20
 > =20
 > -|_eo=20
=20
Regards,
Przemek



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---