Received: from listserv.local (listserv [172.16.8.22])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id A0017780E93;
	Wed, 12 Jan 2022 06:15:41 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
To: Thiago Perrotta <tbperrotta@gmail.com>
From: Kevin Daudt <no-reply@dispatch.alpinelinux.org>
Cc: alpine-aports@lists.alpinelinux.org
In-Reply-To: <20211211213812.35264-1-tbperrotta@gmail.com>
Subject: Re: [PATCH] testing/fpp: new aport
Date: Wed, 12 Jan 2022 06:15:41 -0000
Message-ID: 
 <164196814162.985.12615730476664762936.gitlab.28364.9beb00e1df93735ee93533a88ade5d5c1fd8288a@listserv.local>

On Sat, 11 Dec 2021 16:38:12 -0500, Thiago Perrotta wrote:
> +builddir="$srcdir/PathPicker-$pkgver"
> +
> +prepare() {

Running the command with `--version` is not a good check and can create a false idea that things are working while they aren't.

If the project has no test suite, just mention that and add `options="!check" # no test suite`.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/28364#note_205629