Subject: Re: [alpine-aports] [PATCH] main/zeromq: upgrade to 4.2.2
To: Valery Kartel <valery.kartel@gmail.com>,
 alpine-aports@lists.alpinelinux.org
References: <20170323090937.1038-1-valery.kartel@gmail.com>
From: Leonardo Arena <rnalrd@gmail.com>
Message-ID: <16e4def4-218a-dcf0-2ce1-c2808e3616e8@gmail.com>
Date: Thu, 23 Mar 2017 12:19:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20170323090937.1038-1-valery.kartel@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="4GtV5mWT07hjBvcIEuiUbkfToNbD2JQgL"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4GtV5mWT07hjBvcIEuiUbkfToNbD2JQgL
Content-Type: multipart/mixed; boundary="pNGiBFnpgGse54tnNXXttAdebfoPoAuUV";
 protected-headers="v1"
From: Leonardo Arena <rnalrd@gmail.com>
To: Valery Kartel <valery.kartel@gmail.com>,
 alpine-aports@lists.alpinelinux.org
Message-ID: <16e4def4-218a-dcf0-2ce1-c2808e3616e8@gmail.com>
Subject: Re: [alpine-aports] [PATCH] main/zeromq: upgrade to 4.2.2
References: <20170323090937.1038-1-valery.kartel@gmail.com>
In-Reply-To: <20170323090937.1038-1-valery.kartel@gmail.com>

--pNGiBFnpgGse54tnNXXttAdebfoPoAuUV
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Hi,

On 23/03/2017 10:09, Valery Kartel wrote:
> - add check()
> - cleanups
> ---
>  main/zeromq/APKBUILD | 35 ++++++++++++++---------------------
>  1 file changed, 14 insertions(+), 21 deletions(-)
>=20
> diff --git a/main/zeromq/APKBUILD b/main/zeromq/APKBUILD
> index 02c99c1c27..bba293fd83 100644
> --- a/main/zeromq/APKBUILD
> +++ b/main/zeromq/APKBUILD
> @@ -1,25 +1,17 @@
>  # Contributor: Natanael Copa <ncopa@alpinelinux.org>
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=3Dzeromq
> -pkgver=3D4.1.5
> -pkgrel=3D1
> +pkgver=3D4.2.2
> +pkgrel=3D0
>  pkgdesc=3D"The ZeroMQ messaging library and tools"
>  url=3D"http://www.zeromq.org/"
>  arch=3D"all"
>  license=3D"LGPLv3+ with exceptions"
> -depends=3D""
> -makedepends=3D"util-linux-dev libsodium-dev perl python2 asciidoc xmlt=
o
> -	autoconf automake"
> +makedepends=3D"util-linux-dev libsodium-dev libunwind-dev
> +	perl python2 asciidoc xmlto autoconf automake"
>  subpackages=3D"$pkgname-dev $pkgname-doc libzmq"
> -source=3D"https://github.com/zeromq/zeromq4-1/releases/download/v$pkgv=
er/$pkgname-$pkgver.tar.gz"
> -
> -builddir=3D"$srcdir"/$pkgname-$pkgver
> -
> -prepare() {
> -	cd "$builddir"
> -	update_config_sub || return 1
> -	default_prepare || return 1
> -}
> +source=3D"https://github.com/zeromq/libzmq/releases/download/v$pkgver/=
$pkgname-$pkgver.tar.gz"
> +builddir=3D"$srcdir/$pkgname-$pkgver"
> =20
>  build() {
>  	cd "$builddir"
> @@ -32,20 +24,21 @@ build() {
>  		--infodir=3D/usr/share/info \
>  		--with-libsodium \
>  		|| return 1
> -	make || return 1
> +	make
> +}
> +

If you remove "|| return 1" it might complicate to backport any patch to
stable branches.


> +check() {
> +	make -C "$builddir" check
>  }
> =20

Personally I'd not use "-C" option. I think it's less intuitive and not
in line with current trend.

>  package() {
> -	cd "$builddir"
> -	make DESTDIR=3D"$pkgdir" install || return 1
> +	make -C "$builddir" DESTDIR=3D"$pkgdir" install
>  }

Both previous comments apply here.

Thanks!

|_eo


--pNGiBFnpgGse54tnNXXttAdebfoPoAuUV--

--4GtV5mWT07hjBvcIEuiUbkfToNbD2JQgL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJY069DAAoJELAPckZGG2T6kPwH/3ChIAeHIf+Th8dTkJDiUkrj
PAy43Rv9QPWfbG89FTdHGgSZbhmA7k0kvbGBkEA+cDRyYlZ0ogg2ddKPAOozVYSg
sC2yaWV1QbOl++EUSbBXWaVGhpcxyQcFwJUS5cyKMGRl/mjQjCvIlpGltb1E0ro3
q9i89PzDXsp4h+8QYEqOzavcjtgzmNBbcGm/DRYXKQqGNMwN6EJQIyG4JZrXRMVz
72SbRgXq0lehMTx951C9pot49nIMSgDXOgtVKJmpY4O5OCPZcy3Fw39vTQyhGkU4
sW45WE2VDX2+V7EBCBYyFtmsflqW9xypFiSTYZUfhxJHcpMMOjw8pW1HA5Epma4=
=6vNE
-----END PGP SIGNATURE-----

--4GtV5mWT07hjBvcIEuiUbkfToNbD2JQgL--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---