X-Original-To: alpine-aports@lists.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 96922DC0124; Thu, 1 Jan 2015 15:57:13 +0000 (UTC) Date: Thu, 1 Jan 2015 16:57:10 +0100 From: Natanael Copa To: Sean Summers Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/tomcat-native: new aport Message-ID: <20150101165710.27adeb7b@ncopa-desktop.alpinelinux.org> In-Reply-To: <1420009739-154-1-git-send-email-seansummers@gmail.com> References: <1420009739-154-1-git-send-email-seansummers@gmail.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 31 Dec 2014 07:08:59 +0000 Sean Summers wrote: > http://tomcat.apache.org/native-doc/ > native resources optional component for Apache Tomcat > --- > testing/tomcat-native/APKBUILD | 43 +++++++++++++++++++++++ > testing/tomcat-native/tomcat-native.post-install | 2 ++ > testing/tomcat-native/tomcat-native.pre-deinstall | 2 ++ > 3 files changed, 47 insertions(+) > create mode 100644 testing/tomcat-native/APKBUILD > create mode 100644 testing/tomcat-native/tomcat-native.post-install > create mode 100644 testing/tomcat-native/tomcat-native.pre-deinstall Hi, thanks. Applied, but i have a few questions below. > +depends="apr openssl openjdk7-jre-base" is the apr and openssl dependency due to a library or due to the need for some executable? Library dependencies are normally autodetected. > diff --git a/testing/tomcat-native/tomcat-native.post-install b/testing/tomcat-native/tomcat-native.post-install > new file mode 100644 > index 0000000..1774a04 > --- /dev/null > +++ b/testing/tomcat-native/tomcat-native.post-install > @@ -0,0 +1,2 @@ > +#!/bin/sh > +ln -s libtcnative-1.so.0 /usr/lib/libtcnative-1.so why is the symlink created on install and removed on deinstall instead of shipped as a part of the package? why not something like: diff --git a/testing/tomcat-native/APKBUILD b/testing/tomcat-native/APKBUILD index 6f121b7..1e0da15 100644 --- a/testing/tomcat-native/APKBUILD +++ b/testing/tomcat-native/APKBUILD @@ -7,10 +7,10 @@ pkgdesc="native resources optional component for Apache Tomcat" url="http://tomcat.apache.org/native-doc/" arch="all" license="ASL 2.0" -depends="apr openssl openjdk7-jre-base" +depends="openjdk7-jre-base" depends_dev="apr-dev openssl-dev openjdk7" makedepends="${depends_dev}" -install="${pkgname}.post-install ${pkgname}.pre-deinstall" +install="" subpackages="${pkgname}-dev" source="http://mirrors.gigenet.com/apache/tomcat/tomcat-connectors/native/${pkgver}/source/${pkgname}-${pkgver}-src.tar.gz ${install} @@ -29,7 +29,7 @@ package() { cd "src/${_builddir}" make DESTDIR="${pkgdir}" install || return 1 rm -f ${pkgdir}/usr/lib/*.la || true - rmdir ${pkgdir}/usr/* 2>/dev/null || true + ln -s libtcnative-1.so.0 "$pkgdir"/usr/lib/libtcnative-1.so } md5sums="90b4f55d9e3f3614c7b780500268570b tomcat-native-1.1.32-src.tar.gz -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---