Date: Wed, 21 Jan 2015 13:47:11 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: systmkor <systmkor@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/amap
Message-ID: <20150121134711.31fc8b27@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1421643647-777-1-git-send-email-systmkor@gmail.com>
References: <1421643647-777-1-git-send-email-systmkor@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 18 Jan 2015 21:00:47 -0800
systmkor <systmkor@gmail.com> wrote:

> Next-generation tool for assisting network penetration testing.
> https://www.thc.org/thc-amap/

Not applied due to bad depends. see below.

> ---
>  testing/amap/APKBUILD | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 testing/amap/APKBUILD
> 
> diff --git a/testing/amap/APKBUILD b/testing/amap/APKBUILD
> new file mode 100644
> index 0000000..b6834b0
> --- /dev/null
> +++ b/testing/amap/APKBUILD
> @@ -0,0 +1,70 @@
> +# Contributor: Orion <systmkor@gmail.com>
> +# Maintainer: Orion <systmkor@gmail.com>
> +# Reference
> +#    https://aur.archlinux.org/packages/amap/
> +pkgname=amap
> +pkgver=5.4
> +pkgrel=0
> +pkgdesc="Next-generation tool for assisting network penetration testing."
> +url="https://www.thc.org/thc-amap/"
> +arch="all"
> +license="GPL2 custom"
> +depends="pcre openssl"

I believe both depends are wrong and probably just copied from arch linux.

They ship a bundled pcre-3.9 with the sources, which is used compile
time and linked in statically. This package will just pull in the system
pcre but never use it.

We probably want amap to use system pcre instead of bundled. You can do
that by patching the build scripts or you can run 'make LIB=-lpcre'. I
think i would prefer that it also uses the system pcre headers, just in
case they have introduced any ABI incompatible changes in headers since
3.9.

The openssl is not detected during build time:

Starting amap auto configuration ...

Checking for openssl ...
                     ... NOT found, SSL support disabled


Because you don't pull in the headers, only the openssl runtimes. So
the retulting apk will pull in openssl but never use it.

I think you probably mean to link amap with openssl. To do so you need
to remove it from depends and add openssl-dev to makedepends.

Please fix those two things and resend.


-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---