Date: Sun, 25 Jan 2015 12:27:40 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: AmatCoder <amatcoder@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/geany: fix vte emulation
Message-ID: <20150125122740.0d2a3843@ncopa-laptop>
In-Reply-To: <1421924516-14944-1-git-send-email-amatcoder@gmail.com>
References: <1421924516-14944-1-git-send-email-amatcoder@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 22 Jan 2015 11:01:56 +0000
AmatCoder <amatcoder@gmail.com> wrote:

> Replace only the first 'xterm' because the other is the terminal
> emulation to use and it must be 'xterm'.
> ---
>  main/geany/APKBUILD | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/main/geany/APKBUILD b/main/geany/APKBUILD
> index 12597d0..eceec52 100644
> --- a/main/geany/APKBUILD
> +++ b/main/geany/APKBUILD
> @@ -1,7 +1,7 @@
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=geany
>  pkgver=1.24.1
> -pkgrel=0
> +pkgrel=1
>  pkgdesc="A fast and lightweight IDE"
>  url="http://www.geany.org"
>  arch="all"
> @@ -47,7 +47,7 @@ prepare() {
>                  esac
>          done
>  	# set default terminal to Terminal
> -	sed -e 's/xterm/Terminal/g' \
> +	sed -e '1,/xterm/s/xterm/Terminal/' \
>  		-i src/keyfile.c
>  }
>  

I wonder if it would be better to implement it as a patch instead of
sed. If they for some reason would insert 'xterm' in a comment or
whatever it will break things again.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---