Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Mon, 4 May 2015 15:23:43 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Ramon Soares <ramon@codecraft63.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/ca-certificates: change
 update-ca-certificates lua script to a shell script
Message-ID: <20150504152343.16db675f@vostro>
In-Reply-To: <A8FBC366-C807-4DE0-BFAC-26216032C5FA@codecraft63.com>
References: <1430652096-4857-1-git-send-email-ramon@codecraft63.com>
	<rtpw2d.nns1oy.30z50n-qmf@mx.google.com>
	<A8FBC366-C807-4DE0-BFAC-26216032C5FA@codecraft63.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 4 May 2015 08:48:26 -0300
Ramon Soares <ramon@codecraft63.com> wrote:

> Is really necessary to have performance in this script? 
> 
> To a script that should have little use, I believe the dependency of
> other packages to be unnecessary.

It directly affects the boottime of tmpfs installs, as well as
upgrading packages.

See: http://bugs.alpinelinux.org/issues/2846

The shell script can run 3-20 seconds on ARM, where as the lua version
is 0.25 seconds.

Having to wait extra 20 seconds on boot, or "apk upgrade" is
unacceptable if it's fixed with lua dependency. Especially since lua is
the preferred scripting/interpreted language in alpine.

The total installed size for lua and the posix module is roughly 300
kB. It is still less than bash (700+ kB).

Also; the patch is also incorrect, since the orignal
update-ca-certificates is in the tarball, it should not be copied to
aports. See the original commit introducing the lua script:
http://git.alpinelinux.org/cgit/aports/commit/?id=af18a975d8494f923d0ff3754dd250ffc641b6ef

But that said, we are not going to go back to something that is slower;
just because someone else is doing it. If you find the lua dependency
unacceptable, please rewrite the code in C, or some other compiled
language.

Thanks,
Timo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---