Date: Tue, 28 Jul 2015 17:12:07 -0700
From: Isaac Dunham <ibid.ag@gmail.com>
To: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 3/3] main/ssmtp: fix usage of getaddrinfo
Message-ID: <20150729001206.GB1924@newbook>
References: <1438021564-7176-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1438021564-7176-1-git-send-email-soeren+git@soeren-tempel.net>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Mon, Jul 27, 2015 at 08:26:04PM +0200, S=F6ren Tempel wrote:
> diff --git a/main/ssmtp/inet6-getaddrinfo.patch b/main/ssmtp/inet6-getadd=
rinfo.patch
> +++ b/main/ssmtp/inet6-getaddrinfo.patch
> @@ -0,0 +1,12 @@
> +diff -up ssmtp.orig/ssmtp.c ssmtp/ssmtp.c
> +--- ssmtp.orig/ssmtp.c	2009-11-23 10:55:11.000000000 +0100
> ++++ ssmtp/ssmtp.c	2015-07-27 17:34:12.498140804 +0200
> +@@ -1157,7 +1157,7 @@ int smtp_open(char *host, int port)
> + 	snprintf(servname, sizeof(servname), "%d", port);
> +=20
> + 	/* Check we can reach the host */
> +-	if (getaddrinfo(host, servname, &hints, &ai0)) {
> ++	if (getaddrinfo(host, servname, &hints, &ai0) !=3D 0) {
> + 		log_event(LOG_ERR, "Unable to locate %s", host);
> + 		return(-1);
> + 	}

I'm wondering what this is supposed to do.
In C, "if (function(args))" means "if ((function(args)) !=3D 0)",
so the change doesn't mean anything different.

Thanks,
Isaac Dunham


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---