X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 071F0DC64A8 for ; Thu, 3 Sep 2015 09:05:04 +0000 (UTC) Received: from lithium.8pit.net (lithium.8pit.net [141.101.32.65]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 7B6FBDC6460 for ; Thu, 3 Sep 2015 09:05:03 +0000 (UTC) Received: from localhost (ip5f5ac8f9.dynamic.kabel-deutschland.de [95.90.200.249]); by lithium.8pit.net (OpenSMTPD) with ESMTPSA id 4c198d02; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; for ; Thu, 3 Sep 2015 11:05:01 +0200 (CEST) Date: Thu, 3 Sep 2015 11:05:01 +0200 From: =?iso-8859-1?Q?S=F6ren?= Tempel To: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] Adding XDebug for PHP Message-ID: <20150903090501.GA2825@calcium.lan> References: <1441146034-9893-1-git-send-email-mvenezia@gmail.com> X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1441146034-9893-1-git-send-email-mvenezia@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Virus-Scanned: ClamAV using ClamSMTP On 01.09.15, Michael Venezia wrote: > --- > main/php-xdebug/APKBUILD | 52 ++++++++++++++++++++++++++++++++++++++++= ++++++ > main/php-xdebug/xdebug.ini | 6 ++++++ Again: This needs to be committed to testing/ not to main/. Besides the commit message should be "testing/php-xdebug: new aport". On 01.09.15, Michael Venezia wrote: > +# Contributor: > +# Maintainer: It would be kind of great if this package had a maintainer, don't you want to maintain this package? On 01.09.15, Michael Venezia wrote: > +arch=3D"x86_64" This package should work on x86 and arm too. Please verify this and use arch=3D"all" if it is the case. On 01.09.15, Michael Venezia wrote: > +license=3D"GPL" According to the website xdebug is licensed under a custom license and not under the GPL. Even if it is licensed under the GPL then please specify the GPL version e.g. GPL3. On 01.09.15, Michael Venezia wrote: > +depends_dev=3D"" > +makedepends=3D"$depends_dev php-dev autoconf automake flex bison gawk" Please move php-dev from makedepends to depends_dev. On 01.09.15, Michael Venezia wrote: > +build() { > + cd "$_builddir" > + phpize --clean && phpize || return 1 > + ./configure \ > + --build=3D$CBUILD \ > + --host=3D$CHOST \ > + --prefix=3D/usr \ > + || return 1 > + make -j1 || return 1 > +} Why did you explicitly set the amount of makejobs to 1? If more than one makejob can be used than please add a comment explaining why this is the case. On 01.09.15, Michael Venezia wrote: > +package() { > + cd "$_builddir" > + make -j1 install INSTALL_ROOT=3D"$pkgdir" || return 1 > + install -Dm644 "$srcdir"/xdebug.ini \ > + "$pkgdir"/etc/php/conf.d/xdebug.ini || return 1 > +} Again: Why did you limit the amount of makejobs to 1? S=F6ren. --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---