Date: Sat, 5 Sep 2015 14:04:03 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Michael Venezia <mvenezia@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] Adding XDebug for PHP
Message-ID: <20150905140403.465ab99d@ncopa-laptop>
In-Reply-To: <20150903090501.GA2825@calcium.lan>
References: <1441146034-9893-1-git-send-email-mvenezia@gmail.com>
	<20150903090501.GA2825@calcium.lan>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Michael,

Thank you for your patches.

Do you think you could fix the mentioned issues below and then send a
v2 patch? Same with the feedback on the glog patch.

Please see
http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch

Thanks!

-nc

On Thu, 3 Sep 2015 11:05:01 +0200
S=C3=B6ren Tempel <soeren@soeren-tempel.net> wrote:

> On 01.09.15, Michael Venezia wrote:
> > ---
> >  main/php-xdebug/APKBUILD   | 52 ++++++++++++++++++++++++++++++++++++++=
++++++++
> >  main/php-xdebug/xdebug.ini |  6 ++++++
>=20
> Again: This needs to be committed to testing/ not to main/. Besides the
> commit message should be "testing/php-xdebug: new aport".
>=20
> On 01.09.15, Michael Venezia wrote:
> > +# Contributor:
> > +# Maintainer:
>=20
> It would be kind of great if this package had a maintainer, don't you
> want to maintain this package?
>=20
> On 01.09.15, Michael Venezia wrote:
> > +arch=3D"x86_64"
>=20
> This package should work on x86 and arm too. Please verify this and use
> arch=3D"all" if it is the case.
>=20
> On 01.09.15, Michael Venezia wrote:
> > +license=3D"GPL"
>=20
> According to the website <http://www.xdebug.org/license.php> xdebug is
> licensed under a custom license and not under the GPL. Even if it is
> licensed under the GPL then please specify the GPL version e.g. GPL3.
>=20
> On 01.09.15, Michael Venezia wrote:
> > +depends_dev=3D""
> > +makedepends=3D"$depends_dev php-dev autoconf automake flex bison gawk"
>=20
> Please move php-dev from makedepends to depends_dev.
>=20
> On 01.09.15, Michael Venezia wrote:
> > +build() {
> > +	cd "$_builddir"
> > +	phpize --clean && phpize || return 1
> > +	./configure \
> > +		--build=3D$CBUILD \
> > +		--host=3D$CHOST \
> > +		--prefix=3D/usr \
> > +		|| return 1
> > +	make -j1 || return 1
> > +}
>=20
> Why did you explicitly set the amount of makejobs to 1? If more than one
> makejob can be used than please add a comment explaining why this is the
> case.
>=20
> On 01.09.15, Michael Venezia wrote:
> > +package() {
> > +	cd "$_builddir"
> > +	make -j1 install INSTALL_ROOT=3D"$pkgdir" || return 1
> > +	install -Dm644 "$srcdir"/xdebug.ini \
> > +		"$pkgdir"/etc/php/conf.d/xdebug.ini || return 1
> > +}
>=20
> Again: Why did you limit the amount of makejobs to 1?
>=20
> S=C3=B6ren.
>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
>=20



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---