X-Original-To: alpine-aports@mail.alpinelinux.org
Delivered-To: alpine-aports@mail.alpinelinux.org
Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1])
	by mail.alpinelinux.org (Postfix) with ESMTP id 76F90DC03A2;
	Sat,  5 Sep 2015 12:24:44 +0000 (UTC)
Received: from ncopa-laptop (unknown [79.160.13.130])
	(using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id DD6B6DC00C9;
	Sat,  5 Sep 2015 12:24:43 +0000 (UTC)
Date: Sat, 5 Sep 2015 14:24:39 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Sander Maijers <s.n.maijers@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/xmlsec: new aport
Message-ID: <20150905142439.2df7e0ee@ncopa-laptop>
In-Reply-To: <CAGRPH5WLSrzTnRMNs1RMXU9SHGwN0Ha4LpACgK_V5hoBSi5cfg@mail.gmail.com>
References: <CAGRPH5WLSrzTnRMNs1RMXU9SHGwN0Ha4LpACgK_V5hoBSi5cfg@mail.gmail.com>
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP

On Thu, 3 Sep 2015 16:03:44 +0200
Sander Maijers <s.n.maijers@gmail.com> wrote:

> https://www.aleksey.com/xmlsec
>  Provides a C based implementation for XML Signature Syntax and
> Processing and XML Encryption Syntax and Processing.
> ---
>  testing/xmlsec/APKBUILD | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 testing/xmlsec/APKBUILD

Thanks.

Did you send this patch with git send-email via gmail?

It seems that gmail reformat emails (wrapping some long lines) so the
patch does not apply. I edited manually and then cleaned up minor
things.

See comments below.

-nc

> 
> diff --git a/testing/xmlsec/APKBUILD b/testing/xmlsec/APKBUILD
> new file mode 100644
> index 0000000..adfe180
> --- /dev/null
> +++ b/testing/xmlsec/APKBUILD
> @@ -0,0 +1,49 @@
> +# Contributor: Sander Maijers <S.N.Maijers+Alpine@gmail.com>
> +# Maintainer: Sander Maijers <S.N.Maijers+Alpine@gmail.com>
> +pkgname='xmlsec'
> +pkgver='1.2.20'
> +pkgrel='0'
> +pkgdesc="Provides a C based implementation for XML Signature Syntax
> and Processing and XML Encryption Syntax and Processing."

Something has wrapped the above line. Normally we prefer having a
description that is shorter.

> +url="https://www.aleksey.com/${pkgname}"
> +arch="all"
> +license="MIT"
> +depends="libxml2 libxslt openssl libltdl"

You don't need add the above depedencies (unless it
needs /usr/bin/openssl at runtime). abuild will automatically detect
the dependencies for shared libs.

> +depends_dev=
> +makedepends="${depends_dev} libxml2-dev libxslt-dev openssl-dev libltdl"
> +install=
> +subpackages="${pkgname}-dev ${pkgname}-doc"
> +source="${url}/download/${pkgname}1-${pkgver}.tar.gz"
> +_builddir="${srcdir}/${pkgname}1-${pkgver}"
> +
> +prepare() {
> +    :
> +}
> +
> +build() {
> +    cd "${_builddir}" &&
> +    './configure' \
> +     --build="$CBUILD" \
> + --disable-static \
> + --enable-pkgconfig \
> + --host="$CHOST" \
> + --prefix='/usr' \
> + --with-default-crypto='openssl' &&
> +    make || return 1

Indent does not look good.

> +}
> +
> +check() {
> +    cd "${_builddir}" &&
> +    make -k check || return 1
> +}

We don't (yet) have any way to run check.

> +
> +package() {
> +    cd "${_builddir}" &&
> +    make DESTDIR="${pkgdir}" install || return 1
> +    [ -d "${pkgdir}" ] && find "${pkgdir}"'/usr' -type 'f' -name '*.la' -delete
> +    install -m755 -d "${pkgdir}/usr/share/licenses/${pkgname}" &&
> +    install -m644 'COPYING'
> "${pkgdir}/usr/share/licenses/${pkgname}/" || return 1
> +}
> +
> +md5sums="ce12af00283eb90d9281956524250d6e  xmlsec1-1.2.20.tar.gz"
> +sha256sums="3221593ca50f362b546a0888a1431ad24be1470f96b2469c0e0df5e1c55e7305
>  xmlsec1-1.2.20.tar.gz"
> +sha512sums="2f8d473916abf9822367edbe857fc2e12dc9858d12e790d689d787e439904bd6a452bf631043aa66e7502457ab0815a473657f58fca17a213e2490f5655e5ae5
>  xmlsec1-1.2.20.tar.gz"

checksumlines were wrapped.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---