Date: Tue, 8 Sep 2015 22:48:52 -0700
From: Isaac Dunham <ibid.ag@gmail.com>
To: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v3] testing/fbida: new aport
Message-ID: <20150909054851.GB2695@newbook>
References: <1441655200-7825-1-git-send-email-soeren+git@soeren-tempel.net>
 <1441658551-17451-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1441658551-17451-1-git-send-email-soeren+git@soeren-tempel.net>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Mon, Sep 07, 2015 at 10:42:31PM +0200, S=F6ren Tempel wrote:
> ---
>  testing/fbida/APKBUILD | 64 ++++++++++++++++++++++++++++++++++++++++++++=
++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 testing/fbida/APKBUILD
>=20
> diff --git a/testing/fbida/APKBUILD b/testing/fbida/APKBUILD
> new file mode 100644
> index 0000000..782ef4c
> --- /dev/null
> +++ b/testing/fbida/APKBUILD
> @@ -0,0 +1,64 @@
> +# Contributor: S=F6ren Tempel <soeren+alpine@soeren-tempel.net>
> +# Maintainer: S=F6ren Tempel <soeren+alpine@soeren-tempel.net>
> +pkgname=3Dfbida
> +pkgver=3D2.10
> +pkgrel=3D0
> +pkgdesc=3D"Few applications to display and elementary edit images"
> +url=3D"http://www.kraxel.org/blog/linux/$pkgname/"

Thanks for packaging this; I'd actually been "meaning to" package it,
but never got around to it...

Now, a couple comments on substance:
- the use of _tool and _tool_doc is rather odd, but there's only one point
where I'd actually suggest something different:
for fbida-fbgs, call a new function "fbgs", which will in turn call _tool.

- package naming is somewhat odd, and it's certainly more granular than
usual: the usual split is fbi / ida (+ -doc for each)

- RESDIR should not be set to /usr/share/$pkgname:
no one would think to look for the application defaults there.
The standard location is /etc/X11/app-defaults/<resource name>.

> +arch=3D"all"
> +license=3D"GPL2"
> +depends=3D""
> +depends_dev=3D"giflib-dev libexif-dev motif-dev libpng-dev jpeg-dev"
> +makedepends=3D"$depends_dev linux-headers"
> +install=3D""
> +subpackages=3D"
> +	$pkgname-fbgs:_tool
> +	$pkgname-fbgs-doc:_tool_doc
> +	$pkgname-exiftran:_tool
> +	$pkgname-exiftran-doc:_tool_doc
> +	$pkgname-fbi:_tool
> +	$pkgname-fbi-doc:_tool_doc
> +	$pkgname-ida:_tool
> +	$pkgname-ida-doc:_tool_doc"
> +source=3D"https://www.kraxel.org/releases/${pkgname}/${pkgname}-${pkgver=
}.tar.gz"
> +
> +_builddir=3D"$srcdir"/$pkgname-$pkgver
> +build() {
> +	make verbose=3Dyes \
> +		-C "$_builddir" || return 1
> +}
> +
> +package() {
> +	make DESTDIR=3D"$pkgdir" RESDIR=3D"/usr/share/$pkgname" \
> +		prefix=3D/usr -C "$_builddir" install || return 1
> +}
> +
> +_tool() {
> +	local name=3D$(echo $subpkgname | cut -d '-' -f2)
> +	pkgdesc=3D"$pkgname tool $name"
> +
> +	depends=3D"$pkgname"
> +	if [ "${name}" =3D "fbgs" ]; then
> +		depends=3D"$depends $pkgname-fbi ghostscript"
> +	fi
> +
> +	mkdir -p "$subpkgdir"/usr/bin
> +	mv "$pkgdir"/usr/bin/$name \
> +		"$subpkgdir"/usr/bin/$name || return 1
> +}
> +
> +_tool_doc() {
> +	local name=3D$(echo $subpkgname | cut -d '-' -f2)
> +	pkgdesc=3D"$pkgname tool $name (documentation)"
> +	arch=3D"noarch"
> +	install_if=3D"docs $pkgname=3D$pkgver-r$pkgrel"
> +
> +	mkdir -p "$subpkgdir"/usr/share/man/man1
> +	mv "$pkgdir"/usr/share/man/man1/$name.1 \
> +		"$subpkgdir"/usr/share/man/man1/$name.1 || return 1
> +	gzip -9 "$subpkgdir"/usr/share/man/man1/$name.1 || return 1
> +}
> +
> +md5sums=3D"09460b964b58c2e39b665498eca29018  fbida-2.10.tar.gz"
> +sha256sums=3D"7a5a3aac61b40a6a2bbf716d270a46e2f8e8d5c97e314e927d41398a4d=
0b6cb6  fbida-2.10.tar.gz"
> +sha512sums=3D"b7371c19d68cc7219faca4bbfa464c85df2eb22c7bd737d4f0a6fb3de4=
81497862ca22832801d29bab57285d5a8d7d0b0009e14426efdce2759d47340f5eca6d  fbi=
da-2.10.tar.gz"
> --=20
> 2.5.1
>=20
>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
>=20


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---