Date: Fri, 25 Sep 2015 16:13:22 +0200
From: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
To: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/oath-toolkit: new aport
Message-ID: <20150925141322.GA6041@francium.lan>
References: <1443151257-3396-1-git-send-email-systmkor@gmail.com>
 <1443151257-3396-2-git-send-email-systmkor@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1443151257-3396-2-git-send-email-systmkor@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

Noticed some more things on a second look:

On 24.09.15, systmkor wrote:
> +package() {
> +	cd "$_builddir"
> +	make DESTDIR=3D"$pkgdir" install || return 1
> +
> +	install -D -m 644 COPYING "$pkgdir/usr/share/licenses/$pkgname/LICENSE"=
 || return 1
> +	# libpskc & liboath use the same LICENSE and libpskc doesn't have a COP=
YING file in it's subdir
> +	install -D -m 644 liboath/COPYING "$pkgdir/usr/share/licenses/liboath/L=
ICENSE" || return 1
> +	install -D -m 644 liboath/COPYING "$pkgdir/usr/share/licenses/libpskc/L=
ICENSE" || return 1
> +	# oathtool & pskctool use the same LICENSE and pskctool doesn't have a =
COPYING file in it's subdir
> +	install -D -m 644 oathtool/COPYING "$pkgdir/usr/share/licenses/oathtool=
/LICENSE" || return 1
> +	install -D -m 644 oathtool/COPYING "$pkgdir/usr/share/licenses/pskctool=
/LICENSE" || return 1
> +	install -D -m 644 pam_oath/COPYING "$pkgdir/usr/share/licenses/pam-oath=
/LICENSE" || return 1
> +
> +	install -D -m 644 README "$pkgdir/usr/share/doc/$pkgname/README" || ret=
urn 1
> +	install -D -m 644 AUTHORS "$pkgdir/usr/share/doc/$pkgname/AUHTORS" || r=
eturn 1
> +	install -D -m 644 pam_oath/README "$pkgdir/usr/share/doc/pam-oath/READM=
E" || return 1
> +	install -D -m 644 libpskc/README "$pkgdir/usr/share/doc/libpskc/README"=
 || return 1
> +	rm -f "$pkgdir"/usr/lib/*.la
> +}

Removing *.la files manually isn't necessary they are removed
automatically unless you use the 'libtool' option.

On 24.09.15, systmkor wrote:
> +doc() {
> +	arch=3D"noarch"
> +	depends=3D"
> +	     liboath-doc=3D$pkgver-r$pkgrel=20
> +	     libpskc-doc=3D$pkgver-r$pkgrel
> +	     oathtool-doc=3D$pkgver-r$pkgrel
> +	     pskctool-doc=3D$pkgver-r$pkgrel
> +	     pam-oath-doc=3D$pkgver-r$pkgrel
> +	     "
> +	provides=3D"oath-toolkit-doc=3D$pkgver-r$pkgrel"
> +	pkgdesc=3D"oath-toolkit (documentation)"
> +	mkdir -p ${subpkgdir}/usr/share/doc || return 1
> +	mv ${pkgdir}/usr/share/doc/oath-toolkit ${subpkgdir}/usr/share/doc/ || =
return 1
> +}

Why are you overwriting the default doc subpackage function provided by
abuild? And why does this doc function depend on other doc subpackages?

On 24.09.15, systmkor wrote:
> +dev() {
> +	depends=3D"
> +	     liboath=3D$pkgver-r$pkgrel liboath-doc=3D$pkgver-r$pkgrel liboath-=
dev=3D$pkgver-r$pkgrel
> +	     libpskc=3D$pkgver-r$pkgrel libpskc-doc=3D$pkgver-r$pkgrel libpskc-=
dev=3D$pkgver-r$pkgrel
> +	     oathtool=3D$pkgver-r$pkgrel oathtool-doc=3D$pkgver-r$pkgrel oathto=
ol-dev=3D$pkgver-r$pkgrel
> +	     pskctool=3D$pkgver-r$pkgrel pskctool-doc=3D$pkgver-r$pkgrel pskcto=
ol-dev=3D$pkgver-r$pkgrel
> +	     pam-oath=3D$pkgver-r$pkgrel pam-oath-doc=3D$pkgver-r$pkgrel
> +	     "
> +	provides=3D"oath-toolkit-dev=3D$pkgver-r$pkgrel"
> +	pkgdesc=3D"The OATH Toolkit provide components for building one-time pa=
ssword authentication systems. (development files)"
> +	mkdir -p ${subpkgdir} || return 1
> +}

Again: Why don't you use the default dev subpackage function provided by
abuild, the depends here can be specified in the depends_dev variable.

S=F6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---