Date: Fri, 25 Sep 2015 18:58:29 -0700
From: Isaac Dunham <ibid.ag@gmail.com>
To: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/oath-toolkit: new aport
Message-ID: <20150926015828.GA3026@newbook>
References: <1443151257-3396-1-git-send-email-systmkor@gmail.com>
 <1443151257-3396-2-git-send-email-systmkor@gmail.com>
 <20150925141322.GA6041@francium.lan>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20150925141322.GA6041@francium.lan>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Fri, Sep 25, 2015 at 04:13:22PM +0200, S=F6ren Tempel wrote:
> On 24.09.15, systmkor wrote:
> > +doc() {
> > +	arch=3D"noarch"
> > +	depends=3D"
> > +	     liboath-doc=3D$pkgver-r$pkgrel=20
> > +	     libpskc-doc=3D$pkgver-r$pkgrel
> > +	     oathtool-doc=3D$pkgver-r$pkgrel
> > +	     pskctool-doc=3D$pkgver-r$pkgrel
> > +	     pam-oath-doc=3D$pkgver-r$pkgrel
> > +	     "
> > +	provides=3D"oath-toolkit-doc=3D$pkgver-r$pkgrel"
> > +	pkgdesc=3D"oath-toolkit (documentation)"
> > +	mkdir -p ${subpkgdir}/usr/share/doc || return 1
> > +	mv ${pkgdir}/usr/share/doc/oath-toolkit ${subpkgdir}/usr/share/doc/ |=
| return 1
> > +}
>=20
> Why are you overwriting the default doc subpackage function provided by
> abuild? And why does this doc function depend on other doc subpackages?

It seems this is so you get an oath-toolkit-doc package that drags in all
the documentation.

> On 24.09.15, systmkor wrote:
> > +dev() {
> > +	depends=3D"
> > +	     liboath=3D$pkgver-r$pkgrel liboath-doc=3D$pkgver-r$pkgrel liboat=
h-dev=3D$pkgver-r$pkgrel
> > +	     libpskc=3D$pkgver-r$pkgrel libpskc-doc=3D$pkgver-r$pkgrel libpsk=
c-dev=3D$pkgver-r$pkgrel
> > +	     oathtool=3D$pkgver-r$pkgrel oathtool-doc=3D$pkgver-r$pkgrel oath=
tool-dev=3D$pkgver-r$pkgrel
> > +	     pskctool=3D$pkgver-r$pkgrel pskctool-doc=3D$pkgver-r$pkgrel pskc=
tool-dev=3D$pkgver-r$pkgrel
> > +	     pam-oath=3D$pkgver-r$pkgrel pam-oath-doc=3D$pkgver-r$pkgrel
> > +	     "
> > +	provides=3D"oath-toolkit-dev=3D$pkgver-r$pkgrel"
> > +	pkgdesc=3D"The OATH Toolkit provide components for building one-time =
password authentication systems. (development files)"
> > +	mkdir -p ${subpkgdir} || return 1
> > +}
>=20
> Again: Why don't you use the default dev subpackage function provided by
> abuild, the depends here can be specified in the depends_dev variable.

This seems to be a convenience package for if you want "everything for
developing with the OATH toolkit".


I am somewhat suspicious that needing two metapackages for development
indicates overly aggressive splitting-up.

systmkor, could you give some justification for splitting it into so many
libraries?

How much space does each library take when installed?
Does one of the libraries have more dependencies than another?
Is it likely that someone will link to one library but not the other?

(If space is not in the multi-megabyte range, it's probably too much
division--unless you have a library which some packages use alone
with a smaller set of dependencies.)

Thanks,
Isaac Dunham



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---