X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 54331DC1639 for ; Fri, 9 Oct 2015 07:54:37 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.116]) by mail.alpinelinux.org (Postfix) with ESMTP id 34A5DDC0231 for ; Fri, 9 Oct 2015 07:54:37 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id C30F15A7DC2; Fri, 9 Oct 2015 07:44:10 +0000 (GMT) Date: Fri, 9 Oct 2015 09:54:33 +0200 From: Natanael Copa To: Valery Kartel Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/csync2: Previously commited patches and nossl config patch. No post-install. You won ;) Message-ID: <20151009095433.31b3c0c9@ncopa-desktop.alpinelinux.org> In-Reply-To: <1444210566-1705-1-git-send-email-valery.kartel@gmail.com> References: <1444210566-1705-1-git-send-email-valery.kartel@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 7 Oct 2015 12:36:06 +0300 Valery Kartel wrote: > --- > testing/csync2/APKBUILD | 17 +++++++++++------ > testing/csync2/have-strlcpy.patch | 30 ++++++++++++++++++++++++= ++++++ > testing/csync2/nossl-config.patch | 19 +++++++++++++++++++ > testing/csync2/rsync-strlcpy-disable.patch | 20 -------------------- > 4 files changed, 60 insertions(+), 26 deletions(-) > create mode 100644 testing/csync2/have-strlcpy.patch > create mode 100644 testing/csync2/nossl-config.patch > delete mode 100644 testing/csync2/rsync-strlcpy-disable.patch Thanks! I fixed the commit message. The "No post-install. You won ;)" will make no sense for someone looking at the git log. ... > diff --git a/testing/csync2/have-strlcpy.patch b/testing/csync2/have-strl= cpy.patch > new file mode 100644 > index 0000000..394e1ec > --- /dev/null > +++ b/testing/csync2/have-strlcpy.patch > @@ -0,0 +1,30 @@ > +--- old/configure.ac > ++++ new/configure.ac > +@@ -43,7 +43,7 @@ > + > + > + dnl inspired by rsync's configure.ac > +-AC_CHECK_FUNCS(fchmod setmode open64 mkstemp64) > ++AC_CHECK_FUNCS(strlcpy fchmod setmode open64 mkstemp64) > + AC_CACHE_CHECK([for secure mkstemp],csync_cv_HAVE_SECURE_MKSTEMP,[ > + AC_TRY_RUN([#include > + #include > +--- old/rsync.c > ++++ new/rsync.c > +@@ -38,7 +38,7 @@ > + #include > + #endif > +=20 > +- > ++#ifndef HAVE_STRLCPY > + /* This has been taken from rsync:lib/compat.c */ > +=20 > + /** > +@@ -61,6 +61,7 @@ > + } > + return ret; > + } > ++#endif > +=20 > + /* splits filepath at the last '/', if any, like so: > + * dirname basename filepath This patch is perfect. Have you sent it upstream? If not, could you please = do so? > diff --git a/testing/csync2/nossl-config.patch b/testing/csync2/nossl-con= fig.patch > new file mode 100644 > index 0000000..66e76f8 > --- /dev/null > +++ b/testing/csync2/nossl-config.patch > @@ -0,0 +1,19 @@ > +--- old/csync2.cfg > ++++ new/csync2.cfg > +@@ -4,12 +4,15 @@ > + # Please read the documentation: > + # http://oss.linbit.com/csync2/paper.pdf > +=20 > ++# Do not use ssl by default > ++nossl * *; > ++ I'm not sure I like to simply disable ssl. S=F6ren is right though, we should provide an openssl config if we generate selfsigned cert. I think we need move forward so I applied it as it is. Would be nice to fix it properly though. main/dovecot has an openssl config to genereate a selfsigned cert from post-install. Maybe use that as reference if you want look at it again? -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---