X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 983B0DC1916 for ; Tue, 20 Oct 2015 16:38:38 +0000 (UTC) Received: from lithium.8pit.net (lithium.8pit.net [141.101.32.65]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 15E15DC021A for ; Tue, 20 Oct 2015 16:38:37 +0000 (UTC) Received: from localhost (ip5f5ac97f.dynamic.kabel-deutschland.de [95.90.201.127]); by lithium.8pit.net (OpenSMTPD) with ESMTPSA id fd127f4d; TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; for ; Tue, 20 Oct 2015 18:38:36 +0200 (CEST) Date: Tue, 20 Oct 2015 18:38:35 +0200 From: =?iso-8859-1?Q?S=F6ren?= Tempel To: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/twemproxy: new aport Message-ID: <20151020163835.GB17929@francium.lan> References: X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Virus-Scanned: ClamAV using ClamSMTP On 18.10.15, Yagnesh Mistry wrote: > +package() { > + cd "$_builddir" > + make DESTDIR=3D"$pkgdir" install || return 1 > + install -m644 -D "$srcdir"/$pkgname-$pkgver/conf/nutcracker.yml \ > + "$pkgdir"/etc/$akaname/nutcracker.yml || return 1 > + install -m644 -D > "$srcdir"/$pkgname-$pkgver/conf/nutcracker.leaf.yml \ > + "$pkgdir"/etc/$akaname/nutcracker.leaf.yml || return 1 > + install -m644 -D > "$srcdir"/$pkgname-$pkgver/conf/nutcracker.root.yml \ > + "$pkgdir"/etc/$akaname/nutcracker.root.yml || return 1 > + install -m755 -D "$srcdir"/$akaname.initd \ > + "$pkgdir"/etc/init.d/$akaname || return 1 > + install -m644 -D "$srcdir"/$akaname.confd \ > + "$pkgdir"/etc/conf.d/$akaname || return 1 > + > + install -m0700 -d "$pkgdir"/$_rundir || return 1 > + install -m0700 -d "$pkgdir"/$_logdir || return 1 > +} The indention is completely broken here, please indent everything with tabs instead of spaces. > +doc () { > + default_doc || return 1 > + > + _docs=3D"README.md NOTICE ChangeLog" > + for _doc in $_docs; do > + install -m644 -D "$srcdir"/$pkgname-$pkgver/$_doc \ > + "$pkgdir"/usr/share/doc/$akaname/$_doc || return 1 > + done > + > + install -m644 -D "$srcdir"/$pkgname-$pkgver/LICENSE \ > + "$pkgdir"/usr/share/licenses/$akaname/LICENSE || return 1 > +} Please copy the files in the package function, don't overwrite the doc function unless there is a specific reason to do so. > --- /dev/null > +++ b/testing/twemproxy/nutcracker.confd > @@ -0,0 +1,6 @@ > +CONFFILE=3D/etc/nutcracker/nutcracker.yml > +PIDFILE=3D/var/run/nutcracker/nutcracker.pid > +LOGFILE=3D/var/log/nutcracker/nutcracker.log > +STATSPORT=3D22222 > + > +DAEMON_ARGS=3D"-c $CONFFILE -o $LOGFILE -p $PIDFILE -s $STATSPORT -v 11 = -m > 2048 -d" > diff --git a/testing/twemproxy/nutcracker.initd > b/testing/twemproxy/nutcracker.initd > new file mode 100644 > index 0000000..fc802ff > --- /dev/null > +++ b/testing/twemproxy/nutcracker.initd > @@ -0,0 +1,39 @@ > +#!/sbin/openrc-run > + > +NAME=3D"nutcracker" > +DAEMON=3D/usr/sbin/nutcracker > +USER=3D${USER:-nobody} > + > +CONFFILE=3D${CONFFILE:-/etc/nutcracker/nutcracker.yml} > +PIDFILE=3D/var/run/nutcracker/nutcracker.pid > +LOGFILE=3D/var/log/nutcracker/nutcracker.log > +STATSPORT=3D22222 > + > +DAEMON_ARGS=3D${DAEMON_ARGS:-"-c $CONFFILE -o $LOGFILE -p $PIDFILE -s > $STATSPORT -v 11 -m 2048 -d"} > + > +depend() { > + need net > + after firewall > +} > + > +start() { > + touch $PIDFILE > + chown $USER:$USER -R /var/run/nutcracker > + chmod 755 /var/run/nutcracker > + > + ebegin "Starting ${NAME}: " > + start-stop-daemon --start --quiet \ > + --pidfile ${PIDFILE} \ > + --chuid ${USER}:${USER} \ > + --exec ${DAEMON} -- ${DAEMON_ARGS} > + eend $? > +} > + > +stop() { > + ebegin "Stopping ${NAME}: " > + start-stop-daemon --stop --quiet \ > + --pidfile ${PIDFILE} \ > + --exec ${DAEMON} > + eend $? > +} > + Your service files seem to be a bit too complicated it should be enough to set name, command, command_args and pidfile in this case. Did you take a look at gentoos OpenRC files for this package? S=F6ren. --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---