Date: Tue, 3 Nov 2015 08:49:34 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Daniele Coli <danielsan.dani@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 2/3] main/openvpn: Added description to
 init.d script
Message-ID: <20151103084934.0cc2ac7c@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1446228741-18564-2-git-send-email-danielsan.dani@gmail.com>
References: <1446228741-18564-1-git-send-email-danielsan.dani@gmail.com>
	<1446228741-18564-2-git-send-email-danielsan.dani@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 30 Oct 2015 19:12:20 +0100
Daniele Coli <danielsan.dani@gmail.com> wrote:

> Added description to init.d script in order to make it compliant
> with rc-system and avoid annoying warning messages on syslog.
> ---
>  main/openvpn/APKBUILD      | 6 +++---
>  main/openvpn/openvpn.initd | 2 ++
>  2 files changed, 5 insertions(+), 3 deletions(-)

>>> openvpn: Cleaning temporary build dirs...
>>> openvpn: Checking sha512sums...
openvpn-2.3.8.tar.gz: OK
openvpn.initd: FAILED
sha512sum: WARNING: 1 computed checksum did NOT match
openvpn.confd: OK
openvpn.up: OK
openvpn.down: OK
>>> ERROR: openvpn: all failed
>>> openvpn: Uninstalling dependencies...


> 
> diff --git a/main/openvpn/APKBUILD b/main/openvpn/APKBUILD
> index c8528e1..846fa21 100644
> --- a/main/openvpn/APKBUILD
> +++ b/main/openvpn/APKBUILD
> @@ -1,7 +1,7 @@
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=openvpn
>  pkgver=2.3.8
> -pkgrel=0
> +pkgrel=1
>  pkgdesc="A robust, and highly configurable VPN (Virtual Private Network)"
>  url="http://openvpn.sourceforge.net/"
>  arch="all"
> @@ -74,12 +74,12 @@ pam() {
>  }
>  
>  md5sums="51d996f1f1fc30f501ae251a254effeb  openvpn-2.3.8.tar.gz
> -6587953f1ac10cf9261041b7527a6b55  openvpn.initd
> +5098518a5749197148132593072e1b3b  openvpn.initd
>  9eca88cac6294027ec1bb7be74185c3a  openvpn.confd
>  dc72fecd1a1bcef937603057cd6574b1  openvpn.up
>  dc3ff0bae442b9aedd947b8ffda1687a  openvpn.down"
>  sha256sums="532435eff61c14b44a583f27b72f93e7864e96c95fe51134ec0ad4b1b1107c51  openvpn-2.3.8.tar.gz
> -ab7291aaf161020fb4c27a6f24ef0346c66d86f92d29cbd31723cc305502c247  openvpn.initd
> +fcb9f5e224dc3e73fddf537a15dd9c3c018002d499fa6a4680e747f42bb99609  openvpn.initd

apparently you do change the checksum but abuild still fails. What is going on?

Do you change the checksum manually instead of using 'abuild checksum'?

abuild will not be happy if only 1 of the checksums is correct. All
needs to be correct or abuild will be unhappy.

This was introduced due to md5sum got broken and we needed be backwards
compatible, so instead of simply replace it with other hash, we added
multiple, also in case some of the other checksums got broken.

We should probably change that to a single checksum.

>  330149a83684ddabe413d134d4c8efad4c88b18c2ab67165014deff5f7fffad2  openvpn.confd
>  848da0929c37b2112769232fbbdf61961b6107c6726d4b74d1ceb034b39ad5dd  openvpn.up
>  39debebcd8c899f20e6d355cbc8eaab46e28b83a9f6c33a94c065688a4f3d2c7  openvpn.down"
> diff --git a/main/openvpn/openvpn.initd b/main/openvpn/openvpn.initd
> index a3b2fda..20c142f 100644
> --- a/main/openvpn/openvpn.initd
> +++ b/main/openvpn/openvpn.initd
> @@ -2,6 +2,8 @@
>  # Copyright 1999-2007 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  
> +description="VPN service"
> +
>  VPNDIR=${VPNDIR:-/etc/openvpn}
>  VPN=${SVCNAME#*.}
>  if [ -n "${VPN}" ] && [ ${SVCNAME} != "openvpn" ]; then



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---