Date: Sat, 28 Nov 2015 22:58:32 +1030
From: sillysausage <sillysausage@privatedemail.net>
To: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/3proxy: new aport
Message-ID: <20151128225832.764393f0@palanthas.192.168.1.1>
In-Reply-To: <1448712594-3255-1-git-send-email-sillysausage@privatedemail.net>
References: <1448712594-3255-1-git-send-email-sillysausage@privatedemail.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: list

This is my first aport, so any suggestions/improvements would be
welcome. 

A few questions:


Question 1:
===============

I noticed this when compiling 3proxy:

scanelf: rpath_security_checks(): Security problem NULL DT_RPATH

Not entirely sure what that is about. It seems to be an error I saw
with quite a few of the binaries.

Should I raise this with upstream?

I noticed that upstream seems to have ignored quite a few compiler
warnings. Don't know why developers do that :(


Question 2:
===============

It's also my first OpenRC script, I based it off their sysvinit script:
https://github.com/z3APA3A/3proxy/blob/devel/scripts/rc.d/proxy.sh

Gentoo https://gitweb.gentoo.org/repo/gentoo.git/tree/net-proxy/3proxy/
didn't have an OpenRC script to borrow, so I tried to write my own.


Question 3:
===============
In regard to the moving around of some files. Is that correct? Should I
patch the Makefile.Linux
https://github.com/z3APA3A/3proxy/blob/devel/Makefile.Linux is that a
better approach? in

I had written this with using the following resources.

http://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package
http://wiki.alpinelinux.org/wiki/Creating_patches
http://wiki.alpinelinux.org/wiki/Writing_Init_Scripts
https://wiki.gentoo.org/wiki/Handbook:X86/Working/Initscripts


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---