X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 22D90DC0160 for ; Tue, 15 Dec 2015 08:34:25 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.116]) by mail.alpinelinux.org (Postfix) with ESMTP id 025C4DC00C6 for ; Tue, 15 Dec 2015 08:34:24 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id 0D0295A088D; Tue, 15 Dec 2015 08:23:38 +0000 (GMT) Date: Tue, 15 Dec 2015 09:34:18 +0100 From: Natanael Copa To: Valery Kartel Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] main/mariadb: upgrade to stable 10.1.8 Message-ID: <20151215093418.1e11d4fe@ncopa-desktop.alpinelinux.org> In-Reply-To: <1445213109-6697-1-git-send-email-valery.kartel@gmail.com> References: <1445213109-6697-1-git-send-email-valery.kartel@gmail.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Valery, I have a question on a change that was not clearly explained in the commit message. On Mon, 19 Oct 2015 03:05:09 +0300 Valery Kartel wrote: > --- > main/mariadb/APKBUILD | 19 +++++++------- > main/mariadb/mariadb.initd | 63 +++++++++++++--------------------------------- > 2 files changed, 27 insertions(+), 55 deletions(-) > > diff --git a/main/mariadb/APKBUILD b/main/mariadb/APKBUILD > index 67c6239..7015b78 100644 > --- a/main/mariadb/APKBUILD > +++ b/main/mariadb/APKBUILD > @@ -3,8 +3,8 @@ > # Maintainer: Natanael Copa > > pkgname=mariadb > -pkgver=10.0.21 > -pkgrel=2 > +pkgver=10.1.8 > +pkgrel=0 > pkgdesc="A fast SQL database server" > url="http://www.mariadb.org" > pkgusers="mysql" ... > diff --git a/main/mariadb/mariadb.initd b/main/mariadb/mariadb.initd > index 8409bad..cb2a388 100644 > --- a/main/mariadb/mariadb.initd > +++ b/main/mariadb/mariadb.initd > @@ -1,15 +1,19 @@ > #!/sbin/openrc-run > -# Copyright 1999-2004 Gentoo Foundation > -# Distributed under the terms of the GNU General Public License v2 > -# $Header: /var/cvsroot/gentoo-x86/dev-db/mysql/files/mysql.init,v 1.7 2004/07/14 21:41:15 agriffis Exp $ > > +getconf() { > + v=$(my_print_defaults --mysqld | grep ^--$1) > + [ -z $v ] && echo $2 || echo ${v#*=} > +} > + > +retry="60" > +pidfile=$(getconf pid-file "/run/mysqld/mysqld.pid") > extra_stopped_commands="setup" > -pidfile=/var/run/mysqld/mysqld.pid > +command="/usr/bin/mysqld_safe" > +command_args="--pid-file=$pidfile --syslog --nowatch" > > depend() { > - need net > - after firewall > - use dns > + use net > + need localmount > } Why do we accept that mariadb may be started before the firewall? Isn't that a potensial risk? What was the reason for this change? Why do we remove the 'use dns'? Did it create problems? Did you investigate why it was added in first place? -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---