X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 86BB4DC02A7 for ; Thu, 17 Dec 2015 08:44:04 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.116]) by mail.alpinelinux.org (Postfix) with ESMTP id 5BAF4DC0123 for ; Thu, 17 Dec 2015 08:44:04 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id 48DBA5A1808; Thu, 17 Dec 2015 08:33:18 +0000 (GMT) Date: Thu, 17 Dec 2015 09:43:58 +0100 From: Natanael Copa To: Valery Kartel Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] main/alpine-conf: fix fs-related packages loading, load lvm2 only if _lvm install, remove bashisms, remove installing sfdisk to destination system Message-ID: <20151217094358.69de2ac3@ncopa-desktop.alpinelinux.org> In-Reply-To: <1450184814-2213-1-git-send-email-valery.kartel@gmail.com> References: <1450184814-2213-1-git-send-email-valery.kartel@gmail.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 15 Dec 2015 15:06:54 +0200 Valery Kartel wrote: > --- > .../0003-setup-disk-fix-package-loading.patch | 51 ++++++++++++++++++++++ > main/alpine-conf/APKBUILD | 12 +++-- > 2 files changed, 59 insertions(+), 4 deletions(-) > create mode 100644 main/alpine-conf/0003-setup-disk-fix-package-loading.patch I have already pushed a tested variant of most of your fixes. > diff --git a/main/alpine-conf/0003-setup-disk-fix-package-loading.patch b/main/alpine-conf/0003-setup-disk-fix-package-loading.patch > new file mode 100644 > index 0000000..f79f9cc > --- /dev/null > +++ b/main/alpine-conf/0003-setup-disk-fix-package-loading.patch > @@ -0,0 +1,51 @@ > +--- old/setup-disk.in > ++++ new/setup-disk.in > +@@ -323,7 +323,7 @@ > + cp /etc/apk/keys/* "$mnt"/etc/apk/keys/ > + > + local apkflags="--initdb --quiet --progress --update-cache --clean-protected" > +- local pkgs=$(cat "$mnt"/etc/apk/world "$mnt"/var/lib/apk/world 2>/dev/null) > ++ local pkgs=$(grep -v sfdisk "$mnt"/etc/apk/world "$mnt"/var/lib/apk/world 2>/dev/null) > + pkgs="$pkgs acct linux-$KERNEL_FLAVOR alpine-base" > + if [ "$(rc --sys)" = "XEN0" ]; then > + pkgs="$pkgs xen-hypervisor" I don't you think you tested it because the above change will break the install. I kind of expect patches to be tested and working before they are posted. -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---