Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 19 Jan 2016 14:11:01 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Valery Kartel <valery.kartel@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] main/libspf2: 'spfquery' binary moved to -query
 subpackage, other binary examples are removed
Message-ID: <20160119141101.5af72257@vostro>
In-Reply-To: <1450097413-13305-1-git-send-email-valery.kartel@gmail.com>
References: <1450097413-13305-1-git-send-email-valery.kartel@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 14 Dec 2015 14:50:13 +0200
Valery Kartel <valery.kartel@gmail.com> wrote:

> ---
>  main/libspf2/APKBUILD | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/main/libspf2/APKBUILD b/main/libspf2/APKBUILD
> index 5484e46..103400e 100644
> --- a/main/libspf2/APKBUILD
> +++ b/main/libspf2/APKBUILD
> @@ -1,12 +1,13 @@
> +# Contributor: Valery Kartel <valery.kartel@gmail.com>
>  # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>  pkgname=libspf2
>  pkgver=1.2.10
> -pkgrel=1
> +pkgrel=2
>  pkgdesc="Sender Policy Framework library, a part of the SPF/SRS
> protocol pair." url="http://www.libspf2.org"
>  arch="all"
>  license="LGPL2.1 BSD-2"
> -subpackages="$pkgname-dev"
> +subpackages="$pkgname-dev $pkgname-query"
>  makedepends="autoconf automake libtool"
>  depends=
>  source="http://www.libspf2.org/spf/libspf2-$pkgver.tar.gz
> @@ -44,6 +45,14 @@ package() {
>  	cd "$_builddir"
>  	make DESTDIR="$pkgdir" install || return 1
>  }
> +
> +query() {
> +	pkgdesc="SPF command-line utility"
> +	mkdir -p "$subpkgdir"/usr/bin
> +	mv "$pkgdir"/usr/bin/spfquery "$subpkgdir"/usr/bin/
> +	rm -fr "$pkgdir"/usr/bin

How about spfd? I think that should be kept in the base pkg. The others
can go. Perhaps also use --disable-static to configure to prevent the
static binary building?

Otherwise it looks ok. Care to resend with the above changes?

Thanks,
Timo

> +}
> +
>  md5sums="7bb9937d0705649eaa8646de66dc3562  libspf2-1.2.10.tar.gz
>  24b77cb74901d56de89b24ef10b46b85  0001-provide-dn_skipname.patch
>  6dd2d5f33c5f1a5b7c14eec4c71767cd  libspf2-libreplace-fix.patch



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---