Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 19 Jan 2016 14:35:48 +0200
From: Timo Teras <timo.teras@iki.fi>
To: David Huffman <storedbox@outlook.com>
Cc: "alpine-aports@lists.alpinelinux.org"
 <alpine-aports@lists.alpinelinux.org>, "soeren@soeren-tempel.net"
 <soeren@soeren-tempel.net>
Subject: Re: [alpine-aports] [PATCH] testing/libgflags: new aport
Message-ID: <20160119143548.6014fcd5@vostro>
In-Reply-To: <BAY403-EAS960A43844468A5F50907F3B2F70@phx.gbl>
References: <BAY403-EAS960A43844468A5F50907F3B2F70@phx.gbl>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 9 Jan 2016 12:23:33 -0500
David Huffman <storedbox@outlook.com> wrote:

> Since it only provides a library and not an application, I figured it
> would be preferable for organization purposes. Was I wrong?
>=20
> (Sorry about you getting this twice, my email client apparently isn=E2=80=
=99t
> a fan of replying to mailing lists without some coercion.) Warm
> regards,

Yes, this is the standard practice. library-only stuff is usually
prefixed with lib.

The aport looks good with the exception that it installs:
usr/bin/gflags_completions.sh

Either delete it or make it a subpkg with install_if for bash. See tmux
or grep "bash-completion" in the main/*/APKBUILD for examples.

Please resend that fixed, and I'm happy to apply it.

Thanks,
Timo


> David Huffman
>=20
>=20
> From: S=C3=B6ren Tempel
> Sent: Saturday, January 9, 2016 10:29 AM
> To: alpine-aports@lists.alpinelinux.org
> Cc: storedbox@outlook.com
> Subject: Re: [alpine-aports] [PATCH] testing/libgflags: new aport
>=20
> On 09.01.16, David Huffman wrote:
> > +# Contributor: David Huffman <storedbox@outlook.com>
> > +# Maintainer: David Huffman <storedbox@outlook.com>
> > +pkgname=3Dlibgflags
> > +pkgver=3D2.1.2
> > +_srcname=3Dgflags-$pkgver =20
>=20
> Is there any reason why you called the package libgflags instead of
> simply naming it gflags? Than you wouldn't need the _srcname
> variable...
>=20
> S=C3=B6ren.
>=20



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---