Date: Tue, 19 Jan 2016 07:28:54 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: Corentin Henry <corentinhenry@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports]
Message-ID: <20160119152853.GA11978@newbook>
References: <1453204241-6685-1-git-send-email-corentinhenry@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453204241-6685-1-git-send-email-corentinhenry@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Tue, Jan 19, 2016 at 11:50:37AM +0000, Corentin Henry wrote:
> hi,
> 
> hping3 is a network tool able to send custom TCP/IP packets and to display
> target replies like ping do with ICMP replies. hping3 can handle fragmentation,
> and almost arbitrary packet size and content, using the command line interface.
> 
> this package builds hping with tcl scripting support.
> 
> let me know if there is anything to change, I'm not used yet to packaging.

Looks like a typo in package() (hpin3 should presumably be hping3).

Quote $subpkgdir and $pkgdir ("$subpkgdir").

Send it all as one patch.
New APKBUILDS should be buildable from the start; creating a series of
patches like this:
1/4: add APKBUILD (references 1-foo.patch, 2-bar.patch, 3-baz.patch)
2/4: add 1-foo.patch
3/4: add 2-bar.patch
4/4: add 3-baz.patch

is needlessly cluttered, and likely to break autobuild scripts.
If you refer to a local source file, you should add it, the checksums,
and the reference in one commit.

Thanks,
Isaac Dunham


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---