Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Sat, 23 Jan 2016 23:37:53 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Corentin Henry <corentinhenry@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/httperf: new aport
Message-ID: <20160123233753.6f8dbdcd@vostro>
In-Reply-To: <1452439841-2210-1-git-send-email-corentinhenry@gmail.com>
References: <1452439841-2210-1-git-send-email-corentinhenry@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 10 Jan 2016 15:30:41 +0000
Corentin Henry <corentinhenry@gmail.com> wrote:

>  testing/httperf/APKBUILD | 42
> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42
> insertions(+) create mode 100644 testing/httperf/APKBUILD
> 
> diff --git a/testing/httperf/APKBUILD b/testing/httperf/APKBUILD
> new file mode 100644
> index 0000000..4b494bb
> --- /dev/null
> +++ b/testing/httperf/APKBUILD
> @@ -0,0 +1,42 @@
> +# Contributor:
> +# Maintainer: Corentin Henry <corentinhenry@gmail.com>
> +pkgname=httperf
> +pkgver=0.9.0
> +pkgrel=0
> +pkgdesc="A tool for measuring web server performance."
> +url="https://github.com/httperf/httperf"
> +arch="x86_64"
> +license="GPL2"
> +depends="openssl"

The build system gets ELF binary run-time dependencies automatically.
This is not needed. And is actually harmful, this pulls more than the
required libraries (and technically does not guarantee that the
libraries needed are installed). I removed this for you.

> +depends_dev=""
> +makedepends="openssl-dev"
> +install=""
> +subpackages="$pkgname-doc"
> +source="http://$pkgname.googlecode.com/files/$pkgname-$pkgver.tar.gz"
> +
> +_builddir=$srcdir/$pkgname-$pkgver
> +
> +build() {
> +    cd "$_builddir"
> +    cd $pkgname-$pkgver
> +    export CPPFLAGS=""
> +    export LDFLAGS=""
> +    ./configure --prefix=/usr
> +    make
> +}
> +
> +package() {
> +    cd $_builddir/src
> +    make DESTDIR=$pkgdir install
> +}
> +
> +doc() {
> +    default_doc
> +    cd $_builddir/man
> +    gzip -c httperf.1 > httperf.1.gz
> +    install -Dm644 httperf.1.gz
> "$subpkgdir"/usr/share/doc/$pkgname/httperf.1.gz +}
> +

Looks standard autotools package to me. So standard autotools stuff
works here. I fixed all this to the standard.

And changed indentation to tabs.

Applied with changes.

Thanks,
Timo



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---