Date: Mon, 25 Jan 2016 08:51:31 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Timo Teras <timo.teras@iki.fi>
Cc: Isaac Dunham <ibid.ag@gmail.com>, alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] Exactly when do triggers run?
Message-ID: <20160125085131.54ae8728@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20160123230900.504e2762@vostro>
References: <20160123043942.GB8310@newbook>
	<20160123230900.504e2762@vostro>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 23 Jan 2016 23:09:00 +0200
Timo Teras <timo.teras@iki.fi> wrote:

> On Fri, 22 Jan 2016 20:39:43 -0800
> Isaac Dunham <ibid.ag@gmail.com> wrote:
> 
> > I'm wondering what causes triggers to run.

...

> Currently file deletion does not fire trigger if the match is for the
> file. It does however fire if the match is against a directory. 
> 
> I suppose the above could be considered a bug. It would make more sense
> to fire the trigger, and give the deleted file as argument and leave it
> up to the trigger to figure out that the file does not exist anymore.
> 
> @ncopa Do you think we have triggers that'd break if we add the
> match for deleted files?

No, I don't think any triggers would break if we add match for deleted
files. I think all triggers we have so far only watches directories, so
we should be good.

> Or should there be specific syntax on which type of events (add,
> modify, delete) fire the trigger?

With the above you could easily detect if its deleted or add/modified.
I would think that is enough for most cases? I suspect that you will in
almost all cases want to handle 'modified' the same way as 'add'.

If this shows to not be enough, then maybe add that via env var in
future or similar?

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---