Date: Tue, 2 Feb 2016 06:50:25 +0100
From: Olivier Mauras <olivier@mauras.ch>
To: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 2/3] newapkbuild: remove default
 prepare()
Message-Id: <20160202065025.fc1318a9f038027d2aa32d63@mauras.ch>
In-Reply-To: <1454365949-60951-2-git-send-email-muh.muhten@gmail.com>
References: <1454365949-60951-1-git-send-email-muh.muhten@gmail.com>
	<1454365949-60951-2-git-send-email-muh.muhten@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="PGP-SHA256";
 boundary="Signature=_Tue__2_Feb_2016_06_50_25_+0100_WR6IxeVBB+ZAIx9v"

--Signature=_Tue__2_Feb_2016_06_50_25_+0100_WR6IxeVBB+ZAIx9v
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon,  1 Feb 2016 17:32:28 -0500
Muh Muhten <muh.muhten@gmail.com> wrote:

> Do not add prepare() to new APKBUILDs in the future, as this
> functionality is superseded by the addition of the default prepare
> patcher in abuild.
> ---
>  newapkbuild.in | 15 ---------------
>  1 file changed, 15 deletions(-)
>=20
> diff --git a/newapkbuild.in b/newapkbuild.in
> index a47dcae..64b726b 100644
> --- a/newapkbuild.in
> +++ b/newapkbuild.in
> @@ -224,21 +224,6 @@ __EOF__
>  		fi
>  	fi
> =20
> -
> -	# Create the prepare() template
> -	cat >>APKBUILD<<__EOF__
> -prepare() {
> -	local i
> -	cd "\$_builddir"
> -	for i in \$source; do
> -		case \$i in
> -		*.patch) msg \$i; patch -p1 -i "\$srcdir"/\$i || return 1;;
> -		esac
> -	done
> -}
> -
> -__EOF__
> -
>  	# Create build() function
>  	cat >>APKBUILD<<__EOF__
>  build() {
> --=20
> 2.5.4 (Apple Git-61)
>=20
>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---

Hello,

How does that behave if one adds prepare() back in the APKBUILD? prepare() =
can be used for other things than just patches.

Regards,
Olivier

--Signature=_Tue__2_Feb_2016_06_50_25_+0100_WR6IxeVBB+ZAIx9v
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWsEOhAAoJEJXQwVHPrdN8m54QALo8nXe9n9KFJG+MAdRHo/2q
t6koA6/zGcCb5VXu7BayNJG3ss5df9HDPf/II2luqijgy0XZRwHeoqV4ehI9TC9d
AnHIwO7JjxcpzpQIVhL4U4gJNcMF7ok7/OguyPnU+Kgy/3e1qQxNp7iUA0vNBi0j
Vgc6v5eYK83888aFEeAHU0poGB0tlAKpOlhgOEVWhsxr+wFjuIegB21EKMRP5FqW
IME+scKxLxOxq6L1Ebpw7dD9xmdYKX9jZ0pgrZTxlWXNzWMs7VKpUer/VPNdJsM7
gNxMkvH4eAhYH55IwPQObR+7VHc9ltkAceWSwsFdgmNBLOUKLJydsbHvtEfn2AaR
fsPPSNoIFlOC094B9AFLSjiagNk/xjhRbRAAjTnGg8T+zDiq42I4w2eGIwxznqo7
hsynejPSwzl9laanECwL6eZvyJyS0h/jX1wOiLIFa0PxPfOeOBqhmRYjpXj0twdG
57jza7j7tpbesPt3Du/TIXSjyZOuPE4qq1k47mpSTGf2YizPbMI3HwlapfOy6/a7
KOGwfhFQiWLx5faf/BXb6KJlRHcVn6dAorzgrgmtTeesSuxMhyA9cBoXy5cvhmZj
FelIidET4Mj1eq8+pBjkc5LuiqMknDgxYQhYx2oQZe4tQSjcbe7F0HGC+VW9ZWCN
gcfUdNjKnjTfB4SVfw/7
=uzmY
-----END PGP SIGNATURE-----

--Signature=_Tue__2_Feb_2016_06_50_25_+0100_WR6IxeVBB+ZAIx9v--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---