X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 7D557DC616F for ; Tue, 23 Feb 2016 11:49:35 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 0CA7FDC613E for ; Tue, 23 Feb 2016 11:49:34 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id 78so113273449lfy.3 for ; Tue, 23 Feb 2016 03:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=zw9Tm2jHxzWceQ+ezbl9dvrt61KJbgqilmVqGwA8h/k=; b=VEklqGE7lH+Hi9ryTnNcRKKcGC/ill0IME3bCJK92fNjNjfPZirazSjr6jbWVcz5R1 zL3t0axDRf9SJHRHfhW18XhSNTWa4xgZKuhoTkb3uwlpN5rQMHPwNqCu2MBric8BMIyN VQO5nRcnDb6Bkw65qCvLXbRx51PGq7xV8QloJFx2cXCCBp6lWaq+QlzhFJE+OY5tc5tm YFChLg+RIWJHCJLp1j4+KKbnZXzO40G1aI0ZFv3V0wc4O4+eCFOqyM4QcC6kCe4T4AaU pE4Vknih+4NdPTJu6VG8rK5v9UldnjTTILjBjkHSldEGT1FPzpGxi47tKTsj8YAZHeKd a/2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=zw9Tm2jHxzWceQ+ezbl9dvrt61KJbgqilmVqGwA8h/k=; b=iJ7Lyh14kUFNRZOBIEWwKqOIRHq/r1VK76RMxrIcDt7fKrB1emkeTZv06bMnDKwT7I o/LFd3E75SuZJuGfwLSW+BswoRvxhSaBYJTh6hY3cCIQTtpFE1eaOR6IeRDUKexja2mh ZMK0Z0AMy+XxvrQnhHb0RbBh6OeAK5jYn2va0aztVQPmT2ZkFgOV64xWdeeEwbMOhDrq t4kO6/X2zb3lsyFpsSrQrlAxDbCsFHr2oU7x4ls0bIAz0UFISvuW2FT4pbheGgm3ZolI SYEjwmStNanHhfDnWTAAdkHC6ZzDFKTYbgwEaN6327ExwybgqH4tTYb2kdeMWjX2TOXo u3Eg== X-Gm-Message-State: AG10YOSdNkLfI24IJyQIuVuNGFue0DRy0QR9pwvkTt63mg1ekEP6ZsbCEr1ZRGqjWOoxfA== X-Received: by 10.25.153.15 with SMTP id b15mr12079892lfe.136.1456228172924; Tue, 23 Feb 2016 03:49:32 -0800 (PST) Received: from vostro.util.wtbts.net ([2001:1bc8:101:f402:21a:9fff:fe0c:4022]) by smtp.gmail.com with ESMTPSA id e92sm4069612lfi.48.2016.02.23.03.49.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Feb 2016 03:49:32 -0800 (PST) Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= Date: Tue, 23 Feb 2016 13:49:30 +0200 From: Timo Teras To: Josh Jameson Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] testing/pure-ftpd: added pure-ftpd-doc pkg, added configure params, added --with-extauth to configure line, fixed license to BSD Message-ID: <20160223134930.4ac47644@vostro.util.wtbts.net> In-Reply-To: <14c966e1-448a-43d8-812e-59b4769c1f2f@getmailbird.com> References: <14c966e1-448a-43d8-812e-59b4769c1f2f@getmailbird.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Sun, 07 Feb 2016 20:33:22 +0000 Josh Jameson wrote: > Subject: [PATCH] testing/pure-ftpd: added pure-ftpd-doc pkg, added > configure params, added --with-extauth to configure line, fixed > license to BSD > > https://www.pureftpd.org > Pure FTPD FTP daemon > --- > testing/pure-ftpd/APKBUILD | 53 > ++++++++++++++++++++++------------------------ 1 file changed, 25 > insertions(+), 28 deletions(-) > > diff --git a/testing/pure-ftpd/APKBUILD b/testing/pure-ftpd/APKBUILD > index 8ea894f..f81a1c4 100644 > --- a/testing/pure-ftpd/APKBUILD > +++ b/testing/pure-ftpd/APKBUILD > @@ -1,22 +1,20 @@ > -# Contributor: Douglas Haber > -# Maintainer: Natanael Copa > +# Contributor: Josh Jameson > +# Maintainer: Josh Jameson Please leave old Contributors in; and if changing maintainers leave the old maintainer as contributor. > pkgname=pure-ftpd > -pkgver=1.0.36 > +pkgver=1.0.42 > pkgrel=0 > -pkgdesc="Pure FTPD FTP daemon" > -url="http://pureftpd.org" > -arch="all" > -license="GPL" > -depends= > -depends_dev= > +pkgdesc="Pure FTPD FTP daemon with ext-auth enabled" > +url="https://www.pureftpd.org" > +arch="x86_64" Is there something in the new release that makes it not work on x86 or arm? It would be better to leave arch as 'all' unless there's a reason. > +license="BSD" > +depends="musl" Dependency on musl is implicit, it's not needed here. abuild picks all .so dependencies automatic. > +depends_dev="" > makedepends="$depends_dev" > install="" > -subpackages="" > -source="http://download.pureftpd.org/pub/pure-ftpd/releases/$pkgname-$pkgver.tar.gz > - pure-ftpd.initd > - pure-ftpd.confd" Why are you removing the init.d and conf.d scripts? > +subpackages="$pkgname-doc" > +source="https://download.pureftpd.org/pub/pure-ftpd/releases/pure-ftpd-$pkgver.tar.gz" > > -_builddir="$srcdir/$pkgname-$pkgver" > +_builddir="$srcdir"/"$pkgname"-"$pkgver" > prepare() { > local i > cd "$_builddir" > @@ -30,24 +28,23 @@ prepare() { > build() { > cd "$_builddir" > ./configure --prefix=/usr \ > - --without-humor \ > - --without-unicode \ > - --with-minimal \ > - --with-throttling \ > - || return 1 > + --sysconfdir=/etc \ > + --mandir=/usr/share/man \ > + --infodir=/usr/share/info \ > + --localstatedir=/var \ > + --without-humor \ > + --without-unicode \ > + --with-minimal \ > + --with-throttling \ > + --with-extauth || return 1 > make || return 1 Please fix white space there. We prefer tabs, not spaces. > } > > package() { > cd "$_builddir" > make DESTDIR="$pkgdir" install || return 1 > - install -m755 -D ../$pkgname.initd \ > - "$pkgdir"/etc/init.d/$pkgname || return 1 > - > - install -m644 -D ../$pkgname.confd \ > - "$pkgdir"/etc/conf.d/$pkgname || return 1 > + rm -rf "$pkgdir"/usr/local > } > - This hunk has issues described above. Could you please fix the mentioned issues, or explain in more detail why they are needed and re-submit. Thanks, Timo --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---