X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 157C7DC83DB for ; Tue, 23 Feb 2016 17:44:46 +0000 (UTC) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 9866FDC718F for ; Tue, 23 Feb 2016 17:44:45 +0000 (UTC) Received: by mail-lb0-f175.google.com with SMTP id bc4so105318689lbc.2 for ; Tue, 23 Feb 2016 09:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=UmcrWpvFKDBQHR14ZgVQot6KAWemt6wAgKuH4pL/bqA=; b=cgd3cHQZJGnP+RfAYjMWRNk0sQVRmAxD+JpcFlXl6L8W3bZ3/LT3p2ykUq9ZEY2KBH wRBIWeo6zNDSl2VLEYUYzvfgX1rdMrQvSqBWByqOIt3gH58YKVPMoeQBjYFTdkhJd58q DhyV/adJXm0YNKNDwsYJTT4YgNkrIZaU3Ubu9cVxizOx8xPfXXhwiO/UhnrlMEM6uB82 WZOWeuiuOnHG1RT75mUXRCSC4VdrLuut9PNCWIL5ePSIPfaoyurGKoTkiWZ7aYytX8tn LL8RgCOePLerru/5KdqogQwNzctmoWXDS4FV35HN2Dswyc4IhBCNQ6I3p2190r/3U/fK 1C3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding; bh=UmcrWpvFKDBQHR14ZgVQot6KAWemt6wAgKuH4pL/bqA=; b=IzR/48qVsekcYTWfZxUp61Z/C8K5mMEfGof1LrcJVsc8BvrABIFkcaq5boN7AX9XKt tMobeY7sdtTALBCE1B3FRpRSAG7SBJ5bEMKcgCvc5mr+oE9zADXNpaajzYV4v1Ym/kg4 Kgdu/h8lksRIathPfk/qw3UbLnsd7yWr6xQa2n4bSCJvTfZHoTZy0lYWNe/oulvmxeNu YHKtTSkui1MoXmMvhthBhY1l2vHV/V3uhNyoBtatAv1yEnxwQ6l6VGfoqX+DTJI+DERi zxtvLwdgcB2244uz2ONOOswQXKZUiGZgpFOdhiw/ZUJKYcnzbxbmKfXN2dIAMjQ8QFz2 kwFw== X-Gm-Message-State: AG10YORLugtXcAjEUeSfOKc0bA/0YMd/kKM81IFAXD6tZgYyrgnpsSx7muMrwGBnRHzggw== X-Received: by 10.112.140.169 with SMTP id rh9mr10776964lbb.69.1456249483665; Tue, 23 Feb 2016 09:44:43 -0800 (PST) Received: from vostro ([83.145.235.201]) by smtp.gmail.com with ESMTPSA id h8sm2406153lfg.10.2016.02.23.09.44.42 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 23 Feb 2016 09:44:43 -0800 (PST) Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= Date: Tue, 23 Feb 2016 19:44:40 +0200 From: Timo Teras To: Marc Vertes Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/mongodb: fix for #5117 Message-ID: <20160223194440.3fc44b9a@vostro> In-Reply-To: References: <1456247469-958-1-git-send-email-marc.vertes@ugrid.net> <20160223191612.6f25f25b@vostro> <6B28E7B4-454F-4391-AA4E-498D73DD811A@ugrid.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 23 Feb 2016 18:26:12 +0100 Marc Vertes wrote: > > Le 23 f=C3=A9vr. 2016 =C3=A0 18:18, Marc Vertes = a > > =C3=A9crit : > >=20 > > =20 > >>=20 > >> Technically the getrlimit() is perfectly ok to do on all > >> platforms. But we know glibc returns rlimit anway, so it can be > >> skipped there. > >>=20 > >> I would have put all of the base/size twiddling inside the if(). > >> Then struct rlimit does not need initialization either. But thats > >> a minor thingy. You care to fix that, or should I just apply this? > >> =20 > > Ok, let met fix, test and resubmit. =20 >=20 > Adjusting the base/size outside of if() is necessary if init is not > performed by main thread, which is the case for mongo shell. If you > agree with that, you can commit as it is. No. And that's actually wrong. If you adjust with 2mb for non-main threads, you end up returning wrong info. When adjustment is not done, base is just +=3D size -=3D size, which is no-op. So the current patch is wrong. pthread_getattr_np returns valid and correct data for non-main threads. Only main thread should get the "treatment". Thanks. Also, sorry for pushing my earlier broken patch. I forgot to reset my git tree before pushing the other patches out. --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---