Date: Wed, 24 Feb 2016 18:49:36 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: =?iso-8859-1?Q?Herv=E9?= Rousseau <herve@moulticast.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/rtorrent: Add libxml2-dev to ensure
 xmlrpc/scgi support
Message-ID: <20160225024934.GA9832@newbook>
References: <1456299506-31-1-git-send-email-herve@moulticast.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1456299506-31-1-git-send-email-herve@moulticast.net>
User-Agent: Mutt/1.5.24 (2015-08-30)

On Wed, Feb 24, 2016 at 07:38:26AM +0000, Herv=E9 Rousseau wrote:
> (with correct commit msg/subject it's always better)
>=20
> APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libx=
m2-dev is missing.
> ./configure returns this:
> checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: =
not found
> /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found

I see two issues with this patch:
- you need to bump pkgrel to trigger a rebuild

- that error means that the xmlrpc-c-config script is missing a dependency
that it should have.

In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
it's not possible to use it without libxml2-dev.

Of course, if you fix that, you'd still need to bump rtorrent to pick up
the fix (and possibly more packages).


HTH,
Isaac Dunham

> ---
>  main/rtorrent/APKBUILD | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/main/rtorrent/APKBUILD b/main/rtorrent/APKBUILD
> index 2ef3c4b..49a9462 100644
> --- a/main/rtorrent/APKBUILD
> +++ b/main/rtorrent/APKBUILD
> @@ -8,7 +8,7 @@ pkgdesc=3D"Ncurses BitTorrent client based on libTorrent"
>  url=3D"http://rakshasa.github.io/rtorrent/"
>  license=3D"GPL"
>  arch=3D"all"
> -makedepends=3D"libsigc++-dev libtorrent-dev curl-dev xmlrpc-c-dev ncurse=
s-dev"
> +makedepends=3D"libsigc++-dev libtorrent-dev libxml2-dev curl-dev xmlrpc-=
c-dev ncurses-dev"
>  subpackages=3D"$pkgname-doc"
>  source=3D"http://rtorrent.net/downloads/${pkgname}-${pkgver}.tar.gz"
> =20
> --=20
> 2.6.4
>=20
>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
>=20


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---