X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 993C3DC65B8 for ; Thu, 25 Feb 2016 09:21:32 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.116]) by mail.alpinelinux.org (Postfix) with ESMTP id 70DB9DC0288 for ; Thu, 25 Feb 2016 09:21:32 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (103.63.200.37.customer.cdi.no [37.200.63.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id 77BAB5A1356; Thu, 25 Feb 2016 09:21:31 +0000 (GMT) Date: Thu, 25 Feb 2016 10:21:25 +0100 From: Natanael Copa To: Isaac Dunham Cc: =?ISO-8859-1?B?SGVyduk=?= Rousseau , alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] main/rtorrent: Add libxml2-dev to ensure xmlrpc/scgi support Message-ID: <20160225102125.5af2b450@ncopa-desktop.alpinelinux.org> In-Reply-To: <20160225024934.GA9832@newbook> References: <1456299506-31-1-git-send-email-herve@moulticast.net> <20160225024934.GA9832@newbook> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 24 Feb 2016 18:49:36 -0800 Isaac Dunham wrote: > On Wed, Feb 24, 2016 at 07:38:26AM +0000, Herv=E9 Rousseau wrote: > > (with correct commit msg/subject it's always better) > >=20 > > APKBUILD specifies --with-xmlrpc-c but support isn't enabled because li= bxm2-dev is missing. > > ./configure returns this: > > checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config= : not found > > /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found =20 >=20 > I see two issues with this patch: > - you need to bump pkgrel to trigger a rebuild >=20 > - that error means that the xmlrpc-c-config script is missing a dependency > that it should have. >=20 > In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because > it's not possible to use it without libxml2-dev. >=20 > Of course, if you fix that, you'd still need to bump rtorrent to pick up > the fix (and possibly more packages). I agree with Dunham on all those. I'd also like commit message reformatted (wrap words at 72 chars, remove text that is not intended for the git history) Thanks! -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---