Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 8 Mar 2016 09:05:29 +0200
From: Timo Teras <timo.teras@iki.fi>
To: =?UTF-8?B?U8O2cmVu?= Tempel <soeren+git@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v2 1/2] testing/nldev: new aport
Message-ID: <20160308090529.3905956e@vostro.util.wtbts.net>
In-Reply-To: <1456783120-4135-1-git-send-email-soeren+git@soeren-tempel.net>
References: <1456783120-4135-1-git-send-email-soeren+git@soeren-tempel.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Looks mostly good. But...

On Mon, 29 Feb 2016 22:58:39 +0100
S=C3=B6ren Tempel <soeren+git@soeren-tempel.net> wrote:

> +start_pre() {
> +	if [ -e /proc/self/fd ]; then
> +		rm -f /dev/fd 2>/dev/null
> +		ln -sf /proc/self/fd /dev/fd
> +	fi
> +}

This looks risky. When restarting this may make /dev/fd unavailable
temporarily and break quite a bit of stuff.

Why is this here in the first place? If necessary, perhaps use readlink
to verify if it needs recreation? And is the 'rm' needed, ln -snf
should be able to replace any entry.

Thanks,
Timo




---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---