Date: Wed, 9 Mar 2016 22:30:25 +0100
From: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
To: alpine-aports@lists.alpinelinux.org
Cc: mitch.tishmack@gmail.com
Subject: Re: [alpine-aports] [PATCH 2/3] testing/ghc-bootstrap new aport
Message-ID: <20160309213025.GA32569@francium.embassy.ccchb.de>
References: <1456882136-88608-1-git-send-email-mitch.tishmack@gmail.com>
 <1456882136-88608-3-git-send-email-mitch.tishmack@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1456882136-88608-3-git-send-email-mitch.tishmack@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)

Didn't have the time to take a closer look at this or to actually test
this so far but on a quick first look it looks good so far, only noticed
the following two things:

On 01.03.16, Mitch Tishmack wrote:
> +depends=3D"bash libffi musl zlib gcc binutils-gold ghc-llvm-3.5"

Actually you don't need to explicitly depend on musl and gcc since those
two are part of build-base.

On 01.03.16, Mitch Tishmack wrote:
> +$(GHC_BS):
> +	curl -LO https://downloads.haskell.org/~ghc/$(GHC_VERSION)/$@
> +
> +$(GHC_SRC):
> +	curl -LO https://www.haskell.org/ghc/dist/$(GHC_VERSION)/$@
> +
> +$(CABAL_BS):
> +	curl -LO https://www.haskell.org/cabal/release/cabal-install-$(CABAL_VE=
RSION)/$@
> +
> +$(LLVM_BS):
> +	curl -LO http://llvm.org/releases/$(LLVM_VERSION)/$@
> +
> +$(POLLY_BS):
> +	curl -LO http://llvm.org/releases/$(LLVM_VERSION)/$@

You might want to fetch those by adding them to the source variable in
the APKBUILD otherwise their checksum/integrity is not verified
automatically.

Furthermore I doubt that the Makefile is really needed you could also
add a custom function to your APKBUILD instead even though I am not
quite sure if that would be any cleaner.

S=F6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---