Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Fri, 18 Mar 2016 11:50:37 +0200
From: Timo Teras <timo.teras@iki.fi>
To: "Trevor R.H. Clarke" <trevor@notcows.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 2/6] testing/py-affine: new aport
Message-ID: <20160318115037.138875e9@vostro.util.wtbts.net>
In-Reply-To: <1456710893-45438-2-git-send-email-trevor@notcows.com>
References: <1456710893-45438-1-git-send-email-trevor@notcows.com>
	<1456710893-45438-2-git-send-email-trevor@notcows.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 28 Feb 2016 20:54:49 -0500
"Trevor R.H. Clarke" <trevor@notcows.com> wrote:

> https://github.com/sgillies/affine
> Matrices describing affine transformation of the plane.
> ---
>  testing/py-affine/APKBUILD | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 testing/py-affine/APKBUILD
> 
> diff --git a/testing/py-affine/APKBUILD b/testing/py-affine/APKBUILD
> new file mode 100644
> index 0000000..14969ba
> --- /dev/null
> +++ b/testing/py-affine/APKBUILD
> @@ -0,0 +1,36 @@
> +# Contributor: Trevor R.H. Clarke <trevor@notcows.com>
> +# Maintainer: Trevor R.H. Clarke <trevor@notcows.com>
> +pkgname=py-affine
> +pkgver="1.2.0"
> +pkgrel=0
> +pkgdesc="Matrices describing affine transformation of the plane."
> +url="https://github.com/sgillies/affine"

> +build() {
> +	cd "$_builddir"
> +	pip install affine --no-deps --root "$_builddir"
> +}

Pip is used to download the package and will likely not match the one
listed as pkgver. Please use the real versioned download path so the
build reproducably gives the correct version.

The same applies for patches 3-6. I did apply the first patch along
with the fixup commit flattened to it.

We should probably add some helper to create APKBUILD for pip packages
similar to perl cpan and ruby.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---