Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Sun, 3 Apr 2016 20:18:06 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Nathan Angelacos <nangel@alpinelinux.org>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/kamailio   upgrade to 4.4.0
Message-ID: <20160403201806.49e7125c@vostro>
In-Reply-To: <1459512894-6534-1-git-send-email-nangel@alpinelinux.org>
References: <1459512894-6534-1-git-send-email-nangel@alpinelinux.org>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  1 Apr 2016 12:14:54 +0000
Nathan Angelacos <nangel@alpinelinux.org> wrote:

> ---
>  main/kamailio/0002-mohqueue-v0-12.patch           | 2794
> ---------------------
> main/kamailio/0003-kamdbctl-backslash.patch       |   13 +-
> main/kamailio/0004-remove-spurious-execinfo.patch |   30 +
> main/kamailio/APKBUILD                            |   59 +- 4 files
> changed, 71 insertions(+), 2825 deletions(-) delete mode 100644
> main/kamailio/0002-mohqueue-v0-12.patch create mode 100644
> main/kamailio/0004-remove-spurious-execinfo.patch
> 
> diff --git a/main/kamailio/APKBUILD b/main/kamailio/APKBUILD
> index 2ff4577..093add8 100644
> --- a/main/kamailio/APKBUILD
> +++ b/main/kamailio/APKBUILD
> @@ -12,7 +12,7 @@ _giturl="git://github.com/$pkgname/$pkgname.git"
>  _gittag=HEAD
>  
>  
> -pkgver=4.3.5
> +pkgver=4.4.0
>  pkgrel=0
>  [ -z "${_gitcommit}" ] && _suffix="_src" || _suffix="-${_gitcommit}"

..

>  # - modules depending on curl library
> -_mod_list_utils="utils"
> +_mod_list_utils="utils http_client"
> +
> +# - async http_async_client
> +_mod_list_async_client="http_async_client"
  
..
 
> -md5sums="117e08e69a973cc0c0d63662d2f47109  kamailio-4.3.5_src.tar.gz
> +http_async_client() {
> +	_generic_pkg "Asynchronous HTTP queries support" \
> +		"$_mod_list_http_async_client"
> +}

Seems above you define only _mod_list_async_clients, but later refer to
_mod_list_http_async_client...  and the package I built ended up having
empty http_async_client subpkg. 

Otherwise looks good!


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---