Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Mon, 4 Apr 2016 09:14:55 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Stuart Cardall <developer@it-offshore.co.uk>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v2] testing/php7: add iconv subpkg
Message-ID: <20160404091455.3a27f4a7@vostro.util.wtbts.net>
In-Reply-To: <1459704185-7807-1-git-send-email-developer@it-offshore.co.uk>
References: <1459704185-7807-1-git-send-email-developer@it-offshore.co.uk>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun,  3 Apr 2016 17:23:05 +0000
Stuart Cardall <developer@it-offshore.co.uk> wrote:

> ---
> Changes v1 -> v2:
>  - pkgrel bumped correctly
>  = this should apply cleanly after Valery's 7.0.5 patch sent today
> 
>  testing/php7/APKBUILD            | 27 +++++++++++++++++----------
>  testing/php7/libintl-iconv.patch | 10 ++++++++++
>  2 files changed, 27 insertions(+), 10 deletions(-)
>  create mode 100644 testing/php7/libintl-iconv.patch
> 
> @@ -400,7 +404,7 @@ xsl()		{ _mv_ext xsl $pkgname-dom; }
>  zip()		{ _mv_ext zip; }
>  zlib()		{ _mv_ext zlib; }
>  
> -md5sums="0171201350941327399a5c3e678a86e5  php-7.0.4.tar.bz2
> +md5sums="b15e6836babcbf0aa446678ee38f896b  php-7.0.5.tar.bz2
>  a340f27e83ed4482d2fbb98658ef71cb  php7-fpm.initd
>  25bde13e7894c2930d97fad68d5dd3b3  php7-fpm.logrotate
>  47be6cd1ed92f21579e15bf2003a709f  php7-module.conf

These checksum updates are incorrect and do not apply.

> @@ -0,0 +1,10 @@ +--- php-7.0.4/ext/standard/string.c ++++
> php-7.0.4/ext/standard/string.c.new +@@ -23,6 +23,7 @@
> + /* Synced with php 3.0 revision 1.193 1999-06-16 [ssb] */
> + 
> + #include <stdio.h>
> ++#include <libintl.h>
> + #include "php.h"
> + #include "php_rand.h"
> + #include "php_string.h"

Is this patch really needed?

We had few issues with the gettext-dev package, but it should be finally
fixed now (there turned out to be one busybox ash bug that broke one of
the configure tests in gettext).

I see that main/php enables iconv similary, and does not need a patch
like this.

Thanks,
Timo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---