X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 94417DC07AB for ; Tue, 5 Apr 2016 20:52:45 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.117]) by mail.alpinelinux.org (Postfix) with ESMTP id 712C1DC0500 for ; Tue, 5 Apr 2016 20:52:44 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (229.63.200.37.customer.cdi.no [37.200.63.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id 7A3145A11EC; Tue, 5 Apr 2016 20:52:43 +0000 (GMT) Date: Tue, 5 Apr 2016 22:52:39 +0200 From: Natanael Copa To: Muh Muhten Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/lua-fun: new aport Message-ID: <20160405225239.6540664c@ncopa-desktop.alpinelinux.org> In-Reply-To: <56D53D72.40409@gmail.com> References: <1456478201-4675-1-git-send-email-muh.muhten@gmail.com> <20160301083638.15741544@vostro.util.wtbts.net> <56D53D72.40409@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Sorry for late answer On Tue, 1 Mar 2016 01:57:54 -0500 Muh Muhten wrote: > On 2016-03-01 1:36 AM, Timo Teras wrote: > > On Fri, 26 Feb 2016 04:16:41 -0500 > > Muh Muhten wrote:] > >> --- > >> +_split() { > >> + install_if="lua$1 $pkgname=$pkgver-r$pkgrel" > >> + pkgdesc="$pkgdesc for Lua $1" > >> + > >> + cd "$_builddir" > >> + install -Dm644 fun.lua "$subpkgdir/usr/share/lua/$1/fun.lua" > >> || return 1 +} > > > > It's the same file installed in three separate packages - just to > > separate directory. > > > > I wonder if we should ship this in some common folder. @ncopa Do we > > have any shared lua path that would be usable in all lua versions? I have a shared /usr/share/lua/common dir for lua-penlight. Then the lua5.[123]-penlight packages have symlinks to this common dir. > > Or should this be single package that provides all three files and just > > ships symlinks/hardlinks? I think it depends on how big the file is and how likely it is that you will have it installed for more than one lua version at the same time. penlight is relatively big (450kb) so in that case the extra package overhead for a lua-penlight-shared package is worth it. > Yes, it's unfortunate. Some light inspection (see below) suggests that > *all* lua libs get installed under versioned dirs. Most of our lua > packages seemed to work this way. I don't think hardlinks are a viable > solution, since the versions get split into separate tarballs, which we > can't practically annotate to indicate hardlinks. symlink is at least > possible, but it's not clear how to organise. lua-fun seems to be a single file, 32k, so I don't think its worth the extra effort to ship a -shared package for it. I just pushed it as it was submitted. Thanks! -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---