Date: Mon, 16 May 2016 17:34:52 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Valery Kartel <valery.kartel@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 1/2] main/dovecot: upgrade to 2.2.23,
 update init and logrotate scripts
Message-ID: <20160516173452.4b37bcbb@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1459753686-20614-1-git-send-email-valery.kartel@gmail.com>
References: <1459753686-20614-1-git-send-email-valery.kartel@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

sorry for late response

On Mon,  4 Apr 2016 10:08:06 +0300
Valery Kartel <valery.kartel@gmail.com> wrote:

> ---
>  main/dovecot/APKBUILD          | 20 +++++++-------
>  main/dovecot/dovecot.initd     | 59 +++++++++++++++---------------------------
>  main/dovecot/dovecot.logrotate |  2 +-
>  3 files changed, 32 insertions(+), 49 deletions(-)

...

> -	DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot}
> -	DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid
> -	checkpath --directory --owner dovecot:dovecot --mode 0755 \
> -		${DOVECOT_BASEDIR}
> -}
> -
> -start() {
> -	checkconfig || return 1
> -	ebegin "Starting ${SVCNAME}"
> -	start-stop-daemon --start --exec /usr/sbin/dovecot --pidfile "${DOVECOT_PIDFILE}" -- -c "${DOVECOT_CONF}"
> +start_pre() {
> +	ebegin
> +	doveconf -c $cfgfile -x >/dev/null && \
> +		checkpath --directory ${pidfile%/*}

Should the pidfile directory not be owned by dovecot:dovecot?

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---