X-Original-To: alpine-aports@lists.alpinelinux.org Received: from newmail.tetrasec.net (unknown [172.21.74.12]) by lists.alpinelinux.org (Postfix) with ESMTP id E16D95C4126 for ; Tue, 21 Jun 2016 22:10:02 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (71.63.200.37.customer.cdi.no [37.200.63.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id 3F55A5A084F; Tue, 21 Jun 2016 22:10:02 +0000 (GMT) Date: Wed, 22 Jun 2016 00:09:53 +0200 From: Natanael Copa To: Thomas Boerger Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] community/cf-cli: new aport Message-ID: <20160622000953.56f563ff@ncopa-desktop.copa.dup.pw> In-Reply-To: <1463055771-8174-1-git-send-email-thomas@webhippie.de> References: <1463055771-8174-1-git-send-email-thomas@webhippie.de> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 12 May 2016 12:22:51 +0000 Thomas Boerger wrote: > https://github.com/cloudfoundry/cli > A CLI for Cloud Foundry written in Go > --- > community/cf-cli/APKBUILD | 67 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 community/cf-cli/APKBUILD Hi, thanks for the patch. It does not build for me. > diff --git a/community/cf-cli/APKBUILD b/community/cf-cli/APKBUILD > new file mode 100644 > index 0000000..b0b0e1d > --- /dev/null > +++ b/community/cf-cli/APKBUILD > @@ -0,0 +1,67 @@ > +# Contributor: Thomas Boerger > +# Maintainer: Thomas Boerger > +pkgname=cf-cli Can you please rename it to: pkgname="cloudfoundry-cli" > +pkgver=6.18.0 > +pkgrel=0 > +pkgdesc="A CLI for Cloud Foundry written in Go" > +url="https://github.com/cloudfoundry/cli" > +arch="all" > +license="Apache 2.0" > +depends="" > +depends_dev="" > +makedepends="$depends_dev go bash" > +install="" > +subpackages="" > +source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.gz" > + > +_disturl="dev.alpinelinux.org:/archive/$pkgname/" > +_gourl="github.com/cloudfoundry/cli" > +_builddir="$srcdir"/src/$_gourl Can you please use the source tarball found on https://github.com/cloudfoundry/cli/releases Something like: source="$pkgname-$pkgver.tar.gz::https://github.com/cloudfoundry/cli/archive/v$pkgver.tar.gz" > + > +prepare() { > + local i > + cd "$_builddir" > + for i in $source; do > + case $i in > + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;; > + esac > + done > +} > + > +snapshot() { Please remove the snapshot func and use source tarball from github. > + > +build() { > + cd "$_builddir" || return 1 > + export GOPATH="$srcdir" > + ./bin/build > +} Please be consistent with indentation. I know not everyone agrees on how to indent things but it is best practices to use the indent style of the project you contribute to. Thanks! -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---